Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #2329

Merged
merged 10 commits into from Feb 20, 2021
Merged

Performance improvements #2329

merged 10 commits into from Feb 20, 2021

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 8, 2021

Description

  • Removed all controller action sub-requests
  • Using twig runtime extensions

Before:
1
During change:
2
Afterwards:
3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.14 milestone Feb 8, 2021
composer.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #2329 (c73f52d) into master (9eb25c4) will decrease coverage by 0.00%.
The diff coverage is 98.70%.

@@             Coverage Diff              @@
##             master    #2329      +/-   ##
============================================
- Coverage     93.42%   93.42%   -0.01%     
+ Complexity     5989     5986       -3     
============================================
  Files           542      541       -1     
  Lines         18096    18086      -10     
============================================
- Hits          16906    16896      -10     
  Misses         1190     1190              
Impacted Files Coverage Δ Complexity Δ
src/Twig/Runtime/EncoreExtension.php 100.00% <ø> (ø) 4.00 <0.00> (?)
src/Twig/Runtime/ExporterExtension.php 100.00% <ø> (ø) 3.00 <0.00> (?)
src/EventSubscriber/UserProfileSubscriber.php 92.85% <85.71%> (-1.59%) 6.00 <0.00> (-1.00)
src/Twig/LocaleFormatExtensions.php 98.76% <98.76%> (ø) 34.00 <34.00> (?)
src/EventSubscriber/ThemeOptionsSubscriber.php 90.00% <100.00%> (-0.91%) 13.00 <11.00> (-1.00)
src/EventSubscriber/UserEnvironmentSubscriber.php 93.33% <100.00%> (ø) 6.00 <4.00> (ø)
src/EventSubscriber/UserPreferenceSubscriber.php 100.00% <100.00%> (ø) 8.00 <0.00> (-5.00)
src/Export/Base/AbstractSpreadsheetRenderer.php 91.28% <100.00%> (ø) 115.00 <1.00> (ø)
src/Invoice/Renderer/AbstractTwigRenderer.php 94.44% <100.00%> (-0.56%) 6.00 <0.00> (ø)
src/Repository/WidgetRepository.php 96.15% <100.00%> (+0.32%) 20.00 <2.00> (+2.00)
... and 13 more

@kevinpapst kevinpapst marked this pull request as ready for review February 20, 2021 22:41
@kevinpapst kevinpapst merged commit 607d09a into master Feb 20, 2021
@kevinpapst kevinpapst deleted the performance branch February 20, 2021 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant