Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More columns in spreadsheet exports #2413

Merged
merged 6 commits into from Mar 8, 2021
Merged

More columns in spreadsheet exports #2413

merged 6 commits into from Mar 8, 2021

Conversation

kevinpapst
Copy link
Member

Description

Fixes #2355

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #2413 (56d99ca) into master (30ac5e4) will increase coverage by 0.02%.
The diff coverage is 97.59%.

@@             Coverage Diff              @@
##             master    #2413      +/-   ##
============================================
+ Coverage     92.76%   92.78%   +0.02%     
- Complexity     5977     6006      +29     
============================================
  Files           542      542              
  Lines         18042    18121      +79     
============================================
+ Hits          16736    16813      +77     
- Misses         1306     1308       +2     
Impacted Files Coverage Δ Complexity Δ
src/Entity/Customer.php 99.29% <92.30%> (-0.71%) 87.00 <4.00> (+4.00) ⬇️
src/Entity/Timesheet.php 97.00% <92.85%> (-0.40%) 84.00 <0.00> (+3.00) ⬇️
src/Entity/Activity.php 100.00% <100.00%> (ø) 41.00 <0.00> (+2.00)
src/Entity/Project.php 100.00% <100.00%> (ø) 64.00 <0.00> (+2.00)
src/Export/Base/AbstractSpreadsheetRenderer.php 92.26% <100.00%> (+0.97%) 133.00 <0.00> (+18.00)

@kevinpapst kevinpapst marked this pull request as ready for review March 8, 2021 17:31
@kevinpapst kevinpapst merged commit 0b7d551 into master Mar 8, 2021
@kevinpapst kevinpapst deleted the spreadsheet-fields branch March 8, 2021 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

More columns for the spreadsheet exporter
1 participant