Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve export filename #2958

Merged
merged 1 commit into from Nov 19, 2021
Merged

improve export filename #2958

merged 1 commit into from Nov 19, 2021

Conversation

kevinpapst
Copy link
Member

Description

Will now consist of:

  • a date prefix Ymd (example: 20211119)
  • if query contained exactly 1 customer: dash + the customer name -customer
  • if query contained exactly 1 project: dash + the project name -project
  • if query contained exactly 1 user: dash + the user name -user

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #2958 (ba31541) into master (56d0267) will increase coverage by 0.00%.
The diff coverage is 92.50%.

@@            Coverage Diff            @@
##             master    #2958   +/-   ##
=========================================
  Coverage     92.26%   92.26%           
- Complexity     7847     7858   +11     
=========================================
  Files           689      690    +1     
  Lines         24027    24063   +36     
=========================================
+ Hits          22168    22202   +34     
- Misses         1859     1861    +2     
Impacted Files Coverage Δ
src/Export/Base/PDFRenderer.php 92.30% <50.00%> (-1.70%) ⬇️
src/Export/ExportFilename.php 96.96% <96.96%> (ø)
src/Export/Base/AbstractSpreadsheetRenderer.php 90.13% <100.00%> (+0.02%) ⬆️

@kevinpapst kevinpapst merged commit 8591313 into master Nov 19, 2021
@kevinpapst kevinpapst deleted the export-filename branch November 19, 2021 17:53
@kevinpapst kevinpapst added this to the 1.17 milestone Dec 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant