diff --git a/src/main/java/com/toby/tobyspring/user/dao/DUserDao.java b/src/main/java/com/toby/tobyspring/user/dao/DUserDao.java index a28899e..084b9a6 100644 --- a/src/main/java/com/toby/tobyspring/user/dao/DUserDao.java +++ b/src/main/java/com/toby/tobyspring/user/dao/DUserDao.java @@ -4,12 +4,5 @@ import java.sql.DriverManager; import java.sql.SQLException; -public class DUserDao extends UserDao { - @Override - public Connection getConnection() throws ClassNotFoundException, SQLException { - // D사 db connection - Class.forName("oracle.jdbc.driver.OracleDriver"); - Connection connection = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:orcl", "dahye", "dahye"); - return connection; - } +public class DUserDao { } diff --git a/src/main/java/com/toby/tobyspring/user/dao/NUserDao.java b/src/main/java/com/toby/tobyspring/user/dao/NUserDao.java index 4dacde7..7872853 100644 --- a/src/main/java/com/toby/tobyspring/user/dao/NUserDao.java +++ b/src/main/java/com/toby/tobyspring/user/dao/NUserDao.java @@ -4,12 +4,5 @@ import java.sql.DriverManager; import java.sql.SQLException; -public class NUserDao extends UserDao { - @Override - public Connection getConnection() throws ClassNotFoundException, SQLException { - // N사의 DB 연결 - Class.forName("oracle.jdbc.driver.OracleDriver"); - Connection connection = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:orcl", "dahye", "dahye"); - return connection; - } +public class NUserDao { } diff --git a/src/main/java/com/toby/tobyspring/user/dao/SimpleConnectionMaker.java b/src/main/java/com/toby/tobyspring/user/dao/SimpleConnectionMaker.java new file mode 100644 index 0000000..24bc866 --- /dev/null +++ b/src/main/java/com/toby/tobyspring/user/dao/SimpleConnectionMaker.java @@ -0,0 +1,13 @@ +package com.toby.tobyspring.user.dao; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; + +public class SimpleConnectionMaker { + public Connection makeNewConnection() throws ClassNotFoundException, SQLException { + Class.forName("oracle.jdbc.driver.OracleDriver"); + Connection connection = DriverManager.getConnection("jdbc:oracle:thin:@localhost:1521:orcl", "dahye", "dahye"); + return connection; + } +} diff --git a/src/main/java/com/toby/tobyspring/user/dao/UserDao.java b/src/main/java/com/toby/tobyspring/user/dao/UserDao.java index 0f6507c..e5d3414 100644 --- a/src/main/java/com/toby/tobyspring/user/dao/UserDao.java +++ b/src/main/java/com/toby/tobyspring/user/dao/UserDao.java @@ -5,8 +5,13 @@ import java.sql.*; public abstract class UserDao { + private SimpleConnectionMaker simpleConnectionMaker; + + public UserDao() { + this.simpleConnectionMaker = new SimpleConnectionMaker(); + } public void add(User user) throws ClassNotFoundException, SQLException { - Connection connection = getConnection(); + Connection connection = simpleConnectionMaker.makeNewConnection(); // sql 실행 PreparedStatement preparedStatement = connection.prepareStatement("insert into users(id, name, password) values(?, ?, ?)"); preparedStatement.setString(1, user.getId()); @@ -21,7 +26,7 @@ public void add(User user) throws ClassNotFoundException, SQLException { } public User get(String id) throws ClassNotFoundException, SQLException { - Connection connection = getConnection(); + Connection connection = simpleConnectionMaker.makeNewConnection(); // sql 실행 PreparedStatement preparedStatement = connection.prepareStatement("select * from users where id = ?"); @@ -41,6 +46,4 @@ public User get(String id) throws ClassNotFoundException, SQLException { return user; } - - public abstract Connection getConnection() throws ClassNotFoundException, SQLException; }