Various refactors and bugfixes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, in the non-split case where all modules were generated to stdout, the header would be printed once for every module even if they came from the same input file.
The test harness would reimplement the command-line driver in a simpler form. That was nice, but would also mean that we had no test coverage for the driver. Turn it around so that the test harness now calls the parameterized driver main. No functional change intended.
kimgr
force-pushed
the
test-coverage-driver
branch
from
8cee2e2
to
8d1ba09
Compare
* --outdir is not part of the mutually-exclusive group * Make the action group required so either --parse, --sema or --gen must be specified * Pass --gen from test scripts
Add _maybe_open which acts as a context manager for either a file object (if a filename is provided) or sys.stdout (if '-' is provided). This is a little weird, but makes it much clearer what's going on in main().
kimgr
force-pushed
the
test-coverage-driver
branch
from
8d1ba09
to
c42d107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily covers the command-line driver with tests