Merging AmdModuleCompiler #13

Closed
hnrysmth opened this Issue Feb 13, 2014 · 6 comments

Comments

Projects
None yet
3 participants

I really like that AmdModuleCompiler class. How would you feel about us including that code in our Twig.js fork?

Owner

kimlai commented Feb 13, 2014

Yes sure. I'm not completely happy with it though, making it extend a The ModuleCompiler as it is feels hackish. I was thinking about making the methods compileClassHeader and compileClassFooter abstract, and then having AmdModuleCompiler and GoogModuleCompiler extend ModuleCompiler.

I've only been toying around with both requirejs and twigjs so maybe you'd have some insight about this. I might try it myself if I find the time.

Owner

kimlai commented Feb 13, 2014

Oh cool. Any chance you'd try to merge it upstream ?

@kimlai kimlai closed this Mar 2, 2014

hnrysmth commented Mar 2, 2014

Oops, sorry I forgot to answer this!

To be honest, I think @schmittjoh has a whole bunch of other projects that are keeping him pretty busy these days. I don't want to pile more pull requests onto him. I definitely think this would be a valuable addition to the main Twig.js project, but until that happens I'm happy to look after it in the BaseKit fork.

Since you already contributed several patches to twig.js and seem to know the code base quite well, what do you think if I give you commit access so you can make your changes without going through pull requests?

hnrysmth commented Mar 2, 2014

I think I could cope with that. We're pretty invested in twig.js at @basekit, which means I already have to tread quite carefully in the fork, or I risk breaking the product. It'd be really awesome to get our work merged back into the main repository where everyone else can benefit from it :)

Great :)

I've added you as a collaborator to the repository.

On Sun, Mar 2, 2014 at 10:09 PM, Henry Smith notifications@github.comwrote:

I think I could cope with that. We're pretty invested in twig.js at
@basekit https://github.com/basekit, which means I already have to
tread quite carefully in the fork, or I risk breaking the product. It'd be
really awesome to get our work merged back into the main repository where
everyone else can benefit from it :)

Reply to this email directly or view it on GitHubhttps://github.com/kimlai/melikeyradio/issues/13#issuecomment-36466964
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment