Add support for new targets feature in ember-cli. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: * https://github.com/ember-cli/rfcs/blob/master/complete/0095-standardise-targets.md * https://emberjs.com/blog/2017/03/19/ember-2-12-released.html#toc_targets On older ember-cli versions `project.targets` is undefined, which would cause the default autoprefixer results (same as prior to this change). On newer ember-cli versions the projects own targets are used and manual configuration in `ember-cli-build.js` is not needed.
cibernox
approved these changes
Apr 19, 2017
| @@ -6,20 +6,25 @@ var defaults = require('lodash/defaults'); | |||
|
|
|||
| module.exports = { | |||
| name: 'ember-cli-autoprefixer', | |||
| included: function(app, parentAddon) { | |||
|
|
|||
| included: function(app) { | |||
There was a problem hiding this comment.
If we're node 4 we can use shorthand syntax.
There was a problem hiding this comment.
You're right, but that sounds like something that should be handled separately.
| this.options = defaults(this.app.options.autoprefixer || {}, { | ||
| browsers: this.project.targets && this.project.targets.browsers, |
There was a problem hiding this comment.
It's super convenient that both use the same syntax.
|
How complex would be to add a smoke test that uses two fixtures and mimics the addon being invoked with different targets to see that the output is different? |
|
@kimroen - Friendly ping 😸 |
kimroen
approved these changes
Apr 22, 2017
kimroen
added a commit
that referenced
this pull request
Apr 22, 2017
|
Thank you so much - good work everyone! Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
On older ember-cli versions
project.targetsis undefined, which would cause the default autoprefixer results (same as prior to this change).On newer ember-cli versions the projects own targets are used and manual configuration in
ember-cli-build.jsis not needed.Closes #32.