Fixes #3 Add (optional) support for ARC #5

Closed
wants to merge 1 commit into
from

2 participants

@subtleGradient

After creating a new SkankySDK project, use the Refactor > Convert to Objective-C ARC… command to convert your project to ARC.

KISetPatchInputValue uses object_setInstanceVariable, which isn't allowed in ARC.
I don't know how to rewrite KISetPatchInputValue with ARC support so I removed it.

@subtleGradient subtleGradient Fixes #3 Add (optional) support for ARC
After creating a new SkankySDK project, use the **Refactor > Convert to Objective-C ARC…** command to convert your project to ARC.
693933c
@subtleGradient subtleGradient commented on the diff Oct 25, 2012
include/SkankySDK.h
@@ -128,13 +128,6 @@ static inline BOOL KIOnSnowLeopard()
return NO;
}
-static inline void KISetPatchInputValue(id patch,NSString *portKey,id value)
-{
- QCPort *port = [patch valueForKey:portKey];
- [port setValue:value];
- object_setInstanceVariable([patch valueForKey:portKey],"_updated",(void *)YES);
@subtleGradient
subtleGradient added a line comment Oct 25, 2012

object_setInstanceVariable doesn't support ARC

@subtleGradient
subtleGradient added a line comment Oct 25, 2012

Maybe use

#if __has_feature(objc_arc)
  ...
#endif

I'll have to look up the syntax for reversing the logic there.

@karl-
kineme.net member
karl- added a line comment Jan 4, 2013

Using an #if define sounds good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@karl- karl- was assigned Dec 28, 2012
@karl-
kineme.net member

Closed - pending a way to avoid deleting KISetPatchInputValue.

@karl- karl- closed this Jan 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment