Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename_migrations can fail if migration name does not start with 4 ints #14

Closed
breid1313 opened this issue Jan 12, 2024 · 6 comments
Closed

Comments

@breid1313
Copy link

we have a migration named like 02_some_name. probably bad form, but this package should be resilient to that. I can submit a PR to address this shortly.

@kingbuzzman
Copy link
Owner

Hello, and thank you for submitting the pull request.

This matter should be addressed directly with Django. The capability to make such changes is granted by Django itself, and it's not a feature that this library facilitates. Unless this file is causing a bug that affects the generation or reading of migrations, I regret to inform you that this is considered an invalid change.

@kingbuzzman
Copy link
Owner

Legitimate bug, fixed in #18

@kingbuzzman
Copy link
Owner

@breid1313 can you check if #18 fixes your issue?

@kingbuzzman
Copy link
Owner

PR has been merged, version has been bumped. Let me know if this solved it.

@kingbuzzman
Copy link
Owner

@breid1313?

@kingbuzzman
Copy link
Owner

If this becomes an issue again, feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants