New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#104 - mobile CSS updates for hyde #105

Merged
merged 2 commits into from Aug 18, 2016

Conversation

Projects
None yet
3 participants
@juszczakn
Contributor

juszczakn commented Aug 18, 2016

Issue #104

Firefox mobile did not even attempt to render the site as mobile and you would have to zoom in to read anything. Fixed with meta tag in first commit.

Afterwards, some CSS to try to:

  • clean up the margin
  • justify the font of the main body
  • default images to center of page, full width
  • fix footnote

Some images of before/after. They kinda got jumbled around, the ones with 3 tabs open are before shots.

Tested on Firefox and Chrome mobile on a Motorola E and Chrome/Firefox devtools. Changes should affect phones up until about an iPhone 6 Plus.

Wasn't sure how far to go with some of the stuff like image tag css, and I am by no means a CSS expert, so feel free to give opinions/suggestions.

juszczakn added some commits Aug 18, 2016

Update hyde with mobile css
Max-width is pretty arbitrary, could be adjusted
in the future.
@PuercoPop

This comment has been minimized.

Show comment
Hide comment
@PuercoPop

PuercoPop Aug 18, 2016

Collaborator

@juszczakn Thanks for the PR! The images could be split into before and after more clearly but using the image flowing with the text to differentiate one from the other.

@Ferada I saw you were interested in mobile support, any feedback?

@kingcons any objections? If not I'll go ahead and merge on Sunday

Collaborator

PuercoPop commented Aug 18, 2016

@juszczakn Thanks for the PR! The images could be split into before and after more clearly but using the image flowing with the text to differentiate one from the other.

@Ferada I saw you were interested in mobile support, any feedback?

@kingcons any objections? If not I'll go ahead and merge on Sunday

@kingcons

This comment has been minimized.

Show comment
Hide comment
@kingcons

kingcons Aug 18, 2016

Owner

@PuercoPop 👍 from me. It would be nice if we tried to make the themes a bit more responsive. This seems like a good first step in that direction.

Owner

kingcons commented Aug 18, 2016

@PuercoPop 👍 from me. It would be nice if we tried to make the themes a bit more responsive. This seems like a good first step in that direction.

@PuercoPop PuercoPop merged commit 444698f into kingcons:master Aug 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment