Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W&B lr logging and project naming #80

Merged
merged 7 commits into from
Aug 10, 2021

Conversation

morganmcg1
Copy link
Contributor

@morganmcg1 morganmcg1 commented Aug 8, 2021

Adds:

  • logging of learning rate to Weights & Biases in device_train.py
  • ability to change the W&B project name in the config if needed (for device_train and train.py)
  • wandb_project to the configs
  • name and wandb_project description to doc string
  • updates wandb version to >=11.2

Screenshot 2021-08-08 at 13 08 17

@morganmcg1 morganmcg1 changed the title adds wandb lr logging and project naming Add W&B lr logging and project naming Aug 8, 2021
device_train.py Outdated Show resolved Hide resolved
@kingoflolz
Copy link
Owner

@morganmcg1 Thanks for making this PR, agree with @nostalgebraist about the use of optax step count. Happy to merge once that's updated and merge conflict is resolved

@morganmcg1
Copy link
Contributor Author

morganmcg1 commented Aug 9, 2021

Thanks @kingoflolz, @nostalgebraist for the comments, conflict addressed. Also, wandb_project was moved from the arguments to the config since your last review.

The PR now adds:

  • logging of learning rate to Weights & Biases in device_train.py
  • ability to change the W&B project name in the config (for device_train and train.py)
  • wandb_project to the existing config files
  • name and wandb_project description to doc string
  • updates wandb version to >=0.11.2

@kingoflolz kingoflolz merged commit 8aaa4f9 into kingoflolz:master Aug 10, 2021
@kingoflolz
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants