Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small subtitles on iPad #708

Closed
neckaros opened this issue Dec 30, 2023 · 3 comments
Closed

Small subtitles on iPad #708

neckaros opened this issue Dec 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@neckaros
Copy link

Describe the bug
iPad fall in the iOS category but usually has larger screen

To Reproduce
Play a video with subtitle on iPad

Additional context
from my understanding issue comes from here:

            case .standard:
                #if os(tvOS)
                return 58
                #elseif os(macOS)
                return 26
                #else
                return 16
                #endif

maybe adding a if iPadOS would solve the issue?

            case .standard:
                #if os(tvOS)
                return 58
                #elseif os(macOS)
                return 26
                #else
                if UIDevice.current.userInterfaceIdiom == .pad {
                  return 26
                } else {
                  return 16
                }
                #endif

Also not sure how we are supposed to use the other sizes has
public static var textFontSize = SubtitleModel.Size.standard.rawValue
is a static

@neckaros neckaros added the bug Something isn't working label Dec 30, 2023
@kingslay
Copy link
Owner

你可以发起个Pull requests 改下pad的字体大小

neckaros added a commit to neckaros/KSPlayer that referenced this issue Jan 2, 2024
Add a check for specific iPad display fixing kingslay#708
@neckaros
Copy link
Author

neckaros commented Jan 2, 2024

Submitted PR.

What about the possibility to switch from smaller/small/larger size?

@kingslay
Copy link
Owner

kingslay commented Jan 2, 2024

可以的。这个size属性是一个全局静态变量。外面可以任意更改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants