Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore URLs not supported by tabs.create #104

Conversation

@LoveIsGrief
Copy link
Collaborator

LoveIsGrief commented Oct 10, 2019

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/create

Passing any of the following URLs will fail:

  • chrome: URLs
  • javascript: URLs
  • data: URLs
  • file: URLs (i.e., files on the filesystem. However, to use a file packaged inside the extension, see below)
    privileged about: URLs (for example, about:config, about:addons, about:debugging).
    Non-privileged URLs (e.g., about:blank) are allowed.
  • The New Tab page (about:newtab) can be opened if no value for URL is provided.

Closes #103

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/create

> Passing any of the following URLs will fail:
>
> - chrome: URLs
> - javascript: URLs
> - data: URLs
> - file: URLs (i.e., files on the filesystem. However, to use a file packaged inside the extension, see below)
    privileged about: URLs (for example, about:config, about:addons, about:debugging).
    Non-privileged URLs (e.g., about:blank) are allowed.
> - The New Tab page (about:newtab) can be opened if no value for URL is provided.
@LoveIsGrief LoveIsGrief added the bug label Oct 10, 2019
@LoveIsGrief LoveIsGrief requested a review from kintesh Oct 10, 2019
@kintesh kintesh merged commit 75188a3 into kintesh:master Oct 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.