Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVEditor: Fix delimiter bug (closes #57) #58

Merged
merged 1 commit into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@ethhics
Copy link
Contributor

ethhics commented Mar 27, 2019

This bug had a really simple cause: the code to split host and container
assumed that there would be only one delimiter. Now that regex is in
play, it's likely that whatever the delimiter is decided upon, it will
be found in some host string.

The fix is to assume that the container name doesn't have
the delimiter in it, and therefore the last element in the
delimiter-split array is the container and everything before is the
host.

I haven't tested this in the app but in the console it works.

CSVEditor: Fix delimiter bug (closes #57)
This bug had a really simple cause: the code to split host and container
assumed that there would be only one delimiter. Now that regex is in
play, it's likely that whatever the delimiter is decided upon, it will
be found in some host string.

The fix is to assume that the container name _doesn't_ have
the delimiter in it, and therefore the last element in the
delimiter-split array is the container and everything before is the
host.
@kintesh

kintesh approved these changes Apr 8, 2019

@kintesh kintesh merged commit 1bef0f6 into kintesh:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.