Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill with current URL when adding a new rule #65

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@LoveIsGrief
Copy link
Collaborator

commented Jul 7, 2019

That can make adding items async when the active tab has to be found.
This might make it necessary to make the callers async as well...

The review should reveal if that's necessary

Related to #39

#39 Autofill with current URL when adding a new rule
That can make adding items async when the active tab has to be found.
This might make it necessary to make the callers async as well...
@kintesh

kintesh approved these changes Jul 8, 2019

@kintesh kintesh merged commit 0e5b491 into kintesh:master Jul 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LoveIsGrief LoveIsGrief deleted the LoveIsGrief:containerise-39 branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.