From 176636536ff2934598b9619169a5259ba8279e03 Mon Sep 17 00:00:00 2001 From: Masaharu TASHIRO Date: Thu, 27 Apr 2023 19:01:03 +0900 Subject: [PATCH] refactor: rename the method opening source/sink of repository --- src/record/export/repositories/error.ts | 2 +- .../repositories/localRecordRepositoryFromStream.ts | 8 ++++---- .../repositories/localRecordRepositoryFromStream.ts | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/record/export/repositories/error.ts b/src/record/export/repositories/error.ts index abb5de8be1..1b209ace7b 100644 --- a/src/record/export/repositories/error.ts +++ b/src/record/export/repositories/error.ts @@ -3,7 +3,7 @@ import { CliKintoneError } from "../../../utils/error"; export class RepositoryError extends CliKintoneError { constructor(cause: unknown) { const message = - "An error occurred while exporting records to the data destination"; + "An error occurred while exporting records to the data sink"; super(message, cause); this.name = "RepositoryError"; diff --git a/src/record/export/repositories/localRecordRepositoryFromStream.ts b/src/record/export/repositories/localRecordRepositoryFromStream.ts index 1c931bdd6b..b4661080dd 100644 --- a/src/record/export/repositories/localRecordRepositoryFromStream.ts +++ b/src/record/export/repositories/localRecordRepositoryFromStream.ts @@ -5,16 +5,16 @@ import { stringifierFactory } from "./stringifiers"; export class LocalRecordRepositoryFromStream implements LocalRecordRepository { readonly format = "csv"; - private readonly destination: () => NodeJS.WritableStream; + private readonly openWritableSink: () => NodeJS.WritableStream; private readonly schema: RecordSchema; private readonly useLocalFilePath: boolean; constructor( - destination: () => NodeJS.WritableStream, + openWritableSink: () => NodeJS.WritableStream, schema: RecordSchema, useLocalFilePath: boolean ) { - this.destination = destination; + this.openWritableSink = openWritableSink; this.schema = schema; this.useLocalFilePath = useLocalFilePath; } @@ -24,7 +24,7 @@ export class LocalRecordRepositoryFromStream implements LocalRecordRepository { schema: this.schema, useLocalFilePath: this.useLocalFilePath, }); - stringifier.pipe(this.destination()); + stringifier.pipe(this.openWritableSink()); return stringifier; } } diff --git a/src/record/import/repositories/localRecordRepositoryFromStream.ts b/src/record/import/repositories/localRecordRepositoryFromStream.ts index 444fbdf2d3..5a004eeeb0 100644 --- a/src/record/import/repositories/localRecordRepositoryFromStream.ts +++ b/src/record/import/repositories/localRecordRepositoryFromStream.ts @@ -11,16 +11,16 @@ export class LocalRecordRepositoryFromStream implements LocalRecordRepository { readonly reader: () => AsyncGenerator; constructor( - source: () => NodeJS.ReadableStream, + openReadableSource: () => NodeJS.ReadableStream, format: string, schema: RecordSchema ) { this.format = format; - this.length = () => countRecordsFromCsv(source()); + this.length = () => countRecordsFromCsv(openReadableSource()); switch (format) { case "csv": - this.reader = () => csvReader(source, schema); + this.reader = () => csvReader(openReadableSource, schema); break; default: throw new RepositoryError(