Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `isUrlString` logic #186

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@zaki-yama
Copy link
Contributor

commented Aug 19, 2019

Change isUrlString() logic so that the string like https://localhost:8000/... is judged as URL.

@zaki-yama zaki-yama requested a review from kintone/frontend as a code owner Aug 19, 2019

@pull-assigner pull-assigner bot requested review from pirosikick and sakito21 Aug 19, 2019

@zaki-yama zaki-yama changed the title Fix `isUrlString` Fix `isUrlString` logic Aug 19, 2019

src/util.ts Outdated Show resolved Hide resolved
Add `^` to regex
Co-Authored-By: Hiroyuki ANAI <pirosikick@gmail.com>

@zaki-yama zaki-yama merged commit 3018cba into master Aug 20, 2019

5 checks passed

ci/circleci: node-v10 Your tests passed on CircleCI!
Details
ci/circleci: node-v12 Your tests passed on CircleCI!
Details
ci/circleci: node-v8 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (kintone) No manifest changes detected

@zaki-yama zaki-yama deleted the fix-is-url-string branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.