Skip to content
This repository has been archived by the owner. It is now read-only.

Cleanup and improvements #24

Open
wants to merge 41 commits into
base: master
from

Conversation

@willkoehler
Copy link

willkoehler commented Aug 20, 2014

First of all, thanks for sharing your awesome template. It was a great starting place for my blog.

As I prepared to use this template, I did some code cleanup and a few design tweaks. I tried to do this in a way that could be shared back upstream if desired. I also tried to honor the original design and not change anything that would effect the design or use of the template.

Overview of improvements:

  • Use kramdown in place of maruku (now deprecated)
  • Clean up config.yml
  • Fix RSS feed
  • Clean up and remove unused CSS
  • Add github social icon (thanks @vdragsic)
  • Tweak styling of social icons
  • Improve responsive design, especially for smaller screens like iPhone 5
  • Improve source code highlighting
  • Tweak look of 404 page

I don't expect this PR to be merged as is. I know there's a lot of stuff here. I opened it to start a conversation about merging some of these fixes back into your template. Feel free to say "no thanks" if it's too much. But if you find any of this useful, let me know and we can figure out how to merge the changes.

willkoehler added 30 commits Aug 16, 2014
- Remove items that match the default setting
- Use kramdown instead of maruku
- Remove references to markdown parsers and extensions that aren't being used
- Use default permalink style (with .html extensions)
Twitter Bootstrap was only being used as a css normalize. No need to carry all this css baggage.

Copied the few "non-normalize" parts of _bootstrap.scss into _base.scss
Since url is not a Jekyll param, it feels like it belongs in the 'info' block.
- Enlarge size of github icon
- Fix vertical alignment of twitter black icon
The effect was subtle and specific to the sample background image - to darken the lower portion of the image. A gradient that focuses on the title text and logos would make more sense, but I don't think it's necessary.
- The .container rules didn't effect articles because the article css had more specificity.
- The extra padding on the index page didn't look good. It created too much space.
- Size and align code blocks to match zoomable images
- Code fills width of block to increase room for source code
Missed this margin in 8790190
willkoehler added 2 commits Aug 21, 2014
- fix vertical alignment of FB share button
- adjust spacing between buttons
@willkoehler willkoehler force-pushed the willkoehler:open_source branch from cd858d6 to 808ee69 Aug 21, 2014
@willkoehler willkoehler force-pushed the willkoehler:open_source branch from 808ee69 to 3e7159f Aug 22, 2014
willkoehler added 7 commits Aug 22, 2014
- Margins of headers, paragraphs, code blocks, images, and blockquotes are now uniform
- Scale font sizes and margins with a single change in the article font size rather than individually changing each element.
Needed to add a container div inside article on the index page so it would use the margins defined for the post page. Now everything has the same margin and responsive rules.
- Add XML declaration line
- Remove unneeded "unless post.draft" conditional
- Include entire post content in description. This allows RSS readers to display the entire story.
- Limit to last 20 posts
@matthewmccullough

This comment has been minimized.

Copy link

matthewmccullough commented Jun 6, 2015

👍 on getting this PR merged. I'm using @willkoehler's fork, but would love to see these changed uptreamed. Thanks for all the hard work @willkoehler and I hope @kippt will have time to include them.

@connorjclark

This comment has been minimized.

Copy link

connorjclark commented Jun 30, 2018

Can this be merged upstream? Otherwise, perhaps @willkoehler or someone else might be interested in making this fork its own project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.