Skip to content

Commit

Permalink
[DCCP] Ackvec: fix soft lockup in ackvec handling code
Browse files Browse the repository at this point in the history
A soft lockup existed in the handling of ack vector records.
Specifically, when a tail of the list of ack vector records was
removed, it was possible to end up iterating infinitely on an element
of the tail.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrea Bittau authored and David S. Miller committed Jun 12, 2006
1 parent 289a1e9 commit afec35e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/dccp/ackvec.c
Expand Up @@ -452,6 +452,7 @@ static void dccp_ackvec_check_rcv_ackvector(struct dccp_ackvec *av,
(unsigned long long)
avr->dccpavr_ack_ackno);
dccp_ackvec_throw_record(av, avr);
break;
}
/*
* If it wasn't received, continue scanning... we might
Expand Down

0 comments on commit afec35e

Please sign in to comment.