Skip to content
Commits on Dec 24, 2006
  1. Linux 2.6.20-rc2

    Linus Torvalds committed
  2. Fix up CIFS for "test_clear_page_dirty()" removal

    Linus Torvalds committed
    This also adds he required page "writeback" flag handling, that cifs
    hasn't been doing and that the page dirty flag changes made obvious.
    Acked-by: Steve French <>
    Acked-by: Dave Kleikamp <>
    Signed-off-by: Linus Torvalds <>
Commits on Dec 23, 2006
  1. [PATCH] arch/i386/pci/mmconfig.c tlb flush fix

    OGAWA Hirofumi committed with Linus Torvalds
    We use the fixmap for accessing pci config space in pci_mmcfg_read/write().
    The problem is in pci_exp_set_dev_base(). It is caching a last
    accessed address to avoid calling set_fixmap_nocache() whenever
    pci_mmcfg_read/write() is used.
      static inline void pci_exp_set_dev_base(int bus, int devfn)
    	u32 dev_base = base | (bus << 20) | (devfn << 12);
    	if (dev_base != mmcfg_last_accessed_device) {
    		mmcfg_last_accessed_device = dev_base;
    		set_fixmap_nocache(FIX_PCIE_MCFG, dev_base);
                cpu0                                        cpu1
                /* doesn't flush tlb */
    But if cpus accessed the above order, the second pci_mmcfg_read() on
    cpu0 doesn't flush the TLB, because "mmcfg_last_accessed_device" is
    device-B.  So, second pci_mmcfg_read() on cpu0 accesses a device-A via
    a previous TLB cache. This problem became the cause of several strange
    This patches fixes this situation by adds "mmcfg_last_accessed_cpu" check.
    [ Alternatively, we could make a per-cpu mapping area or something. Not
      that it's probably worth it, but if we wanted to avoid all locking and
      instead just disable preemption, that would be the way to go. --Linus ]
    Signed-off-by: OGAWA Hirofumi <>
    Signed-off-by: OGAWA Hirofumi <>
    Signed-off-by: Linus Torvalds <>
  2. [PATCH] suspend: fix suspend on single-CPU systems

    Ingo Molnar committed with Linus Torvalds
    Clark Williams reported that suspend doesnt work on his laptop on
    2.6.20-rc1-rt kernels. The bug was introduced by the following cleanup
     commit 112cecb
     Author: Siddha, Suresh B <>
     Date:   Wed Dec 6 20:34:31 2006 -0800
        [PATCH] suspend: don't change cpus_allowed for task initiating the suspend
    because with this change 'error' is not initialized to 0 anymore, if
    there are no other online CPUs. (i.e. if the system is single-CPU).
    the fix is the initialize it to 0. The really weird thing is that my
    version of gcc does not warn about this non-initialized variable
    situation ...
    (also fix the kernel printk in the error branch, it was missing a
    Reported-by: Clark Williams <>
    Signed-off-by: Ingo Molnar <>
    Signed-off-by: Linus Torvalds <>
  3. Fix reiserfs after "test_clear_page_dirty()" removal

    Linus Torvalds committed
    Thanks to Len Brown for testing this fix, since while they have in the
    past, none of my machines run reiserfs at the moment.
    Cc: Vladimir V. Saveliev <>
    Acked-by: Len Brown <>
    Signed-off-by: Linus Torvalds <>
  4. Clean up and export cancel_dirty_page() to modules

    Linus Torvalds committed
    Make cancel_dirty_page() act more like all the other dirty and writeback
    accounting functions: test for "mapping" being NULL, and do the
    NR_FILE_DIRY accounting purely based on mapping_cap_account_dirty()).
    Also, add it to the exports, so that modular filesystems can use it.
    Acked-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  5. Merge branch 'release' of git://…

    Linus Torvalds committed
    * 'release' of git:// (68 commits)
      ACPI: replace kmalloc+memset with kzalloc
      ACPI: Add support for acpi_load_table/acpi_unload_table_id
      fbdev: update after backlight argument change
      ACPI: video: Add dev argument for backlight_device_register
      ACPI: Implement acpi_video_get_next_level()
      ACPI: Kconfig - depend on PM rather than selecting it
      ACPI: fix NULL check in drivers/acpi/osl.c
      ACPI: make drivers/acpi/ec.c:ec_ecdt static
      ACPI: prevent processor module from loading on failures
      ACPI: fix single linked list manipulation
      ACPI: ibm_acpi: allow clean removal
      ACPI: fix git automerge failure
      ACPI: ibm_acpi: respond to workqueue update
      ACPI: dock: add uevent to indicate change in device status
      ACPI: ec: Lindent once again
      ACPI: ec: Change #define to enums there possible.
      ACPI: ec: Style changes.
      ACPI: ec: Acquire Global Lock under EC mutex.
      ACPI: ec: Drop udelay() from poll mode. Loop by reading status field instead.
      ACPI: ec: Rename gpe_bit to gpe
Commits on Dec 22, 2006
  1. @holtmann

    [PATCH] Call init_timer() for ISDN PPP CCP reset state timer

    holtmann committed with Linus Torvalds
    The function isdn_ppp_ccp_reset_alloc_state() sets ->timer.function
    and -> and later on calls add_timer() with no init_timer()
    ever done.
    Noted by Al Viro.
    Signed-off-by: Marcel Holtmann <>
    Cc: Al Viro <>
    Cc: Karsten Keil <>
    Signed-off-by: Linus Torvalds <>
  2. Merge

    Linus Torvalds committed
      [UDP]: Fix reversed logic in udp_get_port().
      [IPV6]: Dumb typo in generic csum_ipv6_magic()
      [SCTP]: make 2 functions static
      [SCTP]: Fix typo adaption -> adaptation as per the latest API draft.
      [SCTP]: Don't export include/linux/sctp.h to userspace.
      [TCP]: Fix ambiguity in the `before' relation.
      [ATM] drivers/atm/fore200e.c: Cleanups.
      [ATM]: Remove dead ATM_TNETA1570 option.
      NetLabel: correctly fill in unused CIPSOv4 level and category mappings
      NetLabel: perform input validation earlier on CIPSOv4 DOI add ops
  3. [PATCH] cfq-iosched: tighten allow merge criteria

    Jens Axboe committed with Linus Torvalds
    The logic in cfq_allow_merge() wasn't clear enough - basically allow
    merging for the same queues only.  Do a fast check for 'rq and bio both
    sync/async' before doing the cfqq hash lookup.
    This is verified to work with the fixed elv_try_merge() from commit
    Signed-off-by: Jens Axboe <>
    Signed-off-by: Linus Torvalds <>
  4. [UDP]: Fix reversed logic in udp_get_port().

    David S. Miller committed
    When this code was converted to use sk_for_each() the
    logic for the "best hash chain length" code was reversed,
    breaking everything.
    The original code was of the form:
    			size = 0;
    			do {
    				if (++size >= best_size_so_far)
    					goto next;
    			} while ((sk = sk->next) != NULL);
    			best_size_so_far = size;
    			best = result;
    and this got converted into:
    			sk_for_each(sk2, node, head)
    				if (++size < best_size_so_far) {
    					best_size_so_far = size;
    					best = result;
    Which does something very very different from the original.
    Signed-off-by: David S. Miller <>
  5. [IPV6]: Dumb typo in generic csum_ipv6_magic()

    Al Viro committed with David S. Miller
    ... duh
    Signed-off-by: Al Viro <>
    Signed-off-by: David S. Miller <>
  6. @AdrianBunk

    [SCTP]: make 2 functions static

    AdrianBunk committed with David S. Miller
    This patch makes the following needlessly global functions static:
    - ipv6.c: sctp_inet6addr_event()
    - protocol.c: sctp_inetaddr_event()
    Signed-off-by: Adrian Bunk <>
    Signed-off-by: Sridhar Samudrala <>
    Signed-off-by: David S. Miller <>
  7. [SCTP]: Fix typo adaption -> adaptation as per the latest API draft.

    Ivan Skytte Jorgensen committed with David S. Miller
    Signed-off-by: Ivan Skytte Jorgensen <>
    Signed-off-by: Sridhar Samudrala <>
    Signed-off-by: David S. Miller <>
  8. [SCTP]: Don't export include/linux/sctp.h to userspace.

    Sridhar Samudrala committed with David S. Miller
    This file contains protocol definitions and there are no SCTP apps
    that use this file.
    Signed-off-by: Sridhar Samudrala <>
    Signed-off-by: David S. Miller <>
  9. @grrtrr

    [TCP]: Fix ambiguity in the `before' relation.

    grrtrr committed with David S. Miller
    While looking at DCCP sequence numbers, I stumbled over a problem with
    the following definition of before in tcp.h:
    static inline int before(__u32 seq1, __u32 seq2)
            return (__s32)(seq1-seq2) < 0;
    Problem: This definition suffers from an an ambiguity, i.e. always
               before(a, (a + 2^31) % 2^32)) = 1
               before((a + 2^31) % 2^32), a) = 1
             In text: when the difference between a and b amounts to 2^31,
             a is always considered `before' b, the function can not decide.
             The reason is that implicitly 0 is `before' 1 ... 2^31-1 ... 2^31
    Solution: There is a simple fix, by defining before in such a way that
              0 is no longer `before' 2^31, i.e. 0 `before' 1 ... 2^31-1
              By not using the middle between 0 and 2^32, before can be made
              This is achieved by testing whether seq2-seq1 > 0 (using signed
              32-bit arithmetic).
    I attach a patch to codify this. Also the `after' relation is basically
    a redefinition of `before', it is now defined as a macro after before.
    Signed-off-by: Gerrit Renker <>
    Signed-off-by: David S. Miller <>
  10. @AdrianBunk

    [ATM] drivers/atm/fore200e.c: Cleanups.

    AdrianBunk committed with David S. Miller
    This patch contains the following transformations from custom functions
    to standard kernel version:
    - fore200e_kmalloc() -> kzalloc()
    - fore200e_kfree() -> kfree()
    - fore200e_swap() -> cpu_to_be32()
    Signed-off-by: Adrian Bunk <>
    Signed-off-by: David S. Miller <>
  11. @AdrianBunk

    [ATM]: Remove dead ATM_TNETA1570 option.

    AdrianBunk committed with David S. Miller
    This patch removes the unconverted ATM_TNETA1570 option that also lacks
    any code in the kernel.
    Signed-off-by: Adrian Bunk <>
    Signed-off-by: David S. Miller <>
  12. @pcmoore

    NetLabel: correctly fill in unused CIPSOv4 level and category mappings

    pcmoore committed with David S. Miller
    Back when the original NetLabel patches were being changed to use Netlink
    attributes correctly some code was accidentially dropped which set all of the
    undefined CIPSOv4 level and category mappings to a sentinel value.  The result
    is the mappings data in the kernel contains bogus mappings which always map to
    zero.  This patch restores the old/correct behavior by initializing the mapping
    data to the correct sentinel value.
    Signed-off-by: Paul Moore <>
    Signed-off-by: James Morris <>
  13. @pcmoore

    NetLabel: perform input validation earlier on CIPSOv4 DOI add ops

    pcmoore committed with David S. Miller
    There are a couple of cases where the user input for a CIPSOv4 DOI add
    operation was not being done soon enough; the result was unexpected behavior
    which was resulting in oops/panics/lockups on some platforms.  This patch moves
    the existing input validation code earlier in the code path to protect against
    bogus user input.
    Signed-off-by: Paul Moore <>
    Signed-off-by: James Morris <>
  14. [PATCH] Fix up page_mkclean_one(): virtual caches, s390

    Peter Zijlstra committed with Linus Torvalds
     - add flush_cache_page() for all those virtual indexed cache
     - handle s390.
    Signed-off-by: Peter Zijlstra <>
    Signed-off-by: Linus Torvalds <>
  15. [PATCH] serial/uartlite: Only enable port if request_port succeeded

    Peter Korsgaard committed with Linus Torvalds
    The uartlite driver used to always enable the port even if request_port
    failed causing havoc. This patch fixes it.
    Signed-off-by: Peter Korsgaard <>
    Signed-off-by: Linus Torvalds <>
  16. @ebiederm

    [PATCH] Fix reparenting to the same thread group. (take 2)

    ebiederm committed with Linus Torvalds
    This patch fixes the case when we reparent to a different thread in the
    same thread group.  This modifies the code so that we do not send
    signals and do not change the signal to send to SIGCHLD unless we have
    change the thread group of our parents.  It also suppresses sending
    pdeath_sig in this cas as well since the result of geppid doesn't
    Thanks to Oleg for spotting my bug of only fixing this for non-ptraced
    Signed-off-by: Eric W. Biederman <>
    Cc: Mike Galbraith <>
    Cc: Albert Cahalan <>
    Cc: Andrew Morton <>
    Cc: Roland McGrath <>
    Cc: Ingo Molnar <>
    Cc: Coywolf Qi Hunt <>
    Acked-by: Oleg Nesterov <>
    Signed-off-by: Linus Torvalds <>
  17. [PATCH] build compile.h earlier

    Andrew Morton committed with Linus Torvalds
    compile.h is created super-late in the build.  But proc_misc.c want to include
    it, and it's generally not sane to have a header file in include/linux be
    created at the end of the build: it's either not present or, worse, wrong for
    most of the build.
    So the patch arranges for compile.h to be built at the start of the build
    process.  It also consolidates the compile.h rules with those for version.h
    and utsname.h, so they all get built together.
    I hope.  My chances of having got this right are about 2%.
    Cc: Sam Ravnborg <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  18. [PATCH] sched: fix bad missed wakeups in the i386, x86_64, ia64, ACPI…

    Ingo Molnar committed with Linus Torvalds
    … and APM idle code
    Fernando Lopez-Lezcano reported frequent scheduling latencies and audio
    xruns starting at the 2.6.18-rt kernel, and those problems persisted all
    until current -rt kernels. The latencies were serious and unjustified by
    system load, often in the milliseconds range.
    After a patient and heroic multi-month effort of Fernando, where he
    tested dozens of kernels, tried various configs, boot options,
    test-patches of mine and provided latency traces of those incidents, the
    following 'smoking gun' trace was captured by him:
                     _------=> CPU#
                    / _-----=> irqs-off
                   | / _----=> need-resched
                   || / _---=> hardirq/softirq
                   ||| / _--=> preempt-depth
                   |||| /
                   |||||     delay
       cmd     pid ||||| time  |   caller
          \   /    |||||   \   |   /
      IRQ_19-1479  1D..1    0us : __trace_start_sched_wakeup (try_to_wake_up)
      IRQ_19-1479  1D..1    0us : __trace_start_sched_wakeup <<...>-5856> (37 0)
      IRQ_19-1479  1D..1    0us : __trace_start_sched_wakeup (c01262ba 0 0)
      IRQ_19-1479  1D..1    0us : resched_task (try_to_wake_up)
      IRQ_19-1479  1D..1    0us : __spin_unlock_irqrestore (try_to_wake_up)
      <idle>-0     1...1   11us!: default_idle (cpu_idle)
      <idle>-0     0Dn.1  602us : smp_apic_timer_interrupt (c0103baf 1 0)
       <...>-5856  0D..2  618us : __switch_to (__schedule)
       <...>-5856  0D..2  618us : __schedule <<idle>-0> (20 162)
       <...>-5856  0D..2  619us : __spin_unlock_irq (__schedule)
       <...>-5856  0...1  619us : trace_stop_sched_switched (__schedule)
       <...>-5856  0D..1  619us : trace_stop_sched_switched <<...>-5856> (37 0)
    what is visible in this trace is that CPU#1 ran try_to_wake_up() for
    PID:5856, it placed PID:5856 on CPU#0's runqueue and ran resched_task()
    for CPU#0. But it decided to not send an IPI that no CPU - due to
    TS_POLLING. But CPU#0 never woke up after its NEED_RESCHED bit was set,
    and only rescheduled to PID:5856 upon the next lapic timer IRQ. The
    result was a 600+ usecs latency and a missed wakeup!
    the bug turned out to be an idle-wakeup bug introduced into the mainline
    kernel this summer via an optimization in the x86_64 tree:
        commit 495ab9c
        Author: Andi Kleen <>
        Date:   Mon Jun 26 13:59:11 2006 +0200
        [PATCH] i386/x86-64/ia64: Move polling flag into thread_info_status
        During some profiling I noticed that default_idle causes a lot of
        memory traffic. I think that is caused by the atomic operations
        to clear/set the polling flag in thread_info. There is actually
        no reason to make this atomic - only the idle thread does it
        to itself, other CPUs only read it. So I moved it into ti->status.
    the problem is this type of change:
            if (!hlt_counter && boot_cpu_data.hlt_works_ok) {
    -               clear_thread_flag(TIF_POLLING_NRFLAG);
    +               current_thread_info()->status &= ~TS_POLLING;
                    while (!need_resched()) {
    this changes clear_thread_flag() to an explicit clearing of TS_POLLING.
    clear_thread_flag() is defined as:
            clear_bit(flag, &ti->flags);
    and clear_bit() is a LOCK-ed atomic instruction on all x86 platforms:
      static inline void clear_bit(int nr, volatile unsigned long * addr)
              __asm__ __volatile__( LOCK_PREFIX
                      "btrl %1,%0"
    hence smp_mb__after_clear_bit() is defined as a simple compile barrier:
      #define smp_mb__after_clear_bit()       barrier()
    but the explicit TS_POLLING clearing introduced by the patch:
    +               current_thread_info()->status &= ~TS_POLLING;
    is not an atomic op! So the clearing of the TS_POLLING bit is freely
    reorderable with the reading of the NEED_RESCHED bit - and both now
    reside in different memory addresses.
    CPU idle wakeup very much depends on ordered memory ops, the clearing of
    the TS_POLLING flag must always be done before we test need_resched()
    and hit the idle instruction(s). [Symmetrically, the wakeup code needs
    to set NEED_RESCHED before it tests the TS_POLLING flag, so memory
    ordering is paramount.]
    Fernando's dual-core Athlon64 system has a sufficiently advanced memory
    ordering model so that it triggered this scenario very often.
    ( And it also turned out that the reason why these latencies never
      triggered on my testsystems is that i routinely use idle=poll, which
      was the only idle variant not affected by this bug. )
    The fix is to change the smp_mb__after_clear_bit() to an smp_mb(), to
    act as an absolute barrier between the TS_POLLING write and the
    NEED_RESCHED read. This affects almost all idling methods (default,
    ACPI, APM), on all 3 x86 architectures: i386, x86_64, ia64.
    Signed-off-by: Ingo Molnar <>
    Tested-by: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  19. [PATCH] jbd: wait for already submitted t_sync_datalist buffer to com…

    Hisashi Hifumi committed with Linus Torvalds
    In the current jbd code, if a buffer on BJ_SyncData list is dirty and not
    locked, the buffer is refiled to BJ_Locked list, submitted to the IO and
    waited for IO completion.
    But the fsstress test showed the case that when a buffer was already
    submitted to the IO just before the buffer_dirty(bh) check, the buffer was
    not waited for IO completion.
    Following patch solves this problem.  If it is assumed that a buffer is
    submitted to the IO before the buffer_dirty(bh) check and still being
    written to disk, this buffer is refiled to BJ_Locked list.
    Signed-off-by: Hisashi Hifumi <>
    Cc: Jan Kara <>
    Cc: "Stephen C. Tweedie" <>
    Cc: <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  20. [PATCH] fix s3c24xx gpio driver (include linux/workqueue.h)

    Ben Dooks committed with Linus Torvalds
    The general gpio driver includes seem to now depend on having
    <linux/workqueue.h> included before they are.
    Signed-off-by: Ben Dooks <>
    Signed-off-by: David Brownell <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  21. @neilbrown

    [PATCH] md: fix a few problems with the interface (sysfs and ioctl) t…

    neilbrown committed with Linus Torvalds
    …o md
    While developing more functionality in mdadm I found some bugs in md...
    - When we remove a device from an inactive array (write 'remove' to
      the 'state' sysfs file - see 'state_store') would should not
      update the superblock information - as we may not have
      read and processed it all properly yet.
    - initialise all raid_disk entries to '-1' else the 'slot sysfs file
      will claim '0' for all devices in an array before the array is
    - all '\n' not to be present at the end of words written to
      sysfs files
    - when we use SET_ARRAY_INFO to set the md metadata version,
      set the flag to say that there is persistant metadata.
    - allow GET_BITMAP_FILE to be called on an array that hasn't
      been started yet.
    Signed-off-by: Neil Brown <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  22. [PATCH] increase CARDBUS_MEM_SIZE

    Andrew Morton committed with Linus Torvalds
    Linus sayeth:
    Google knows everything, and finds, on MS own site no less:
      "Windows 2000 default resources:
       One 4K memory window
       One 2 MB memory window
       Two 256-byte I/O windows"
    which is clearly utterly bogus and insufficient. But Microsoft apparently
    realized this, and:
      "Windows XP default resources:
       Because one memory window of 4K and one window of 2 MB are not
       sufficient for CardBus controllers in many configurations, Windows XP
       allocates larger memory windows to CardBus controllers where possible.
       However, resource windows are static (that is, the operating system
       does not dynamically allocate larger memory windows if new devices
       appear.) Under Windows XP, CardBus controllers will be assigned the
       following resources:
       One 4K memory window, as in Windows 2000
       64 MB memory, if that amount of memory is available. If 64 MB is not
       available the controller will receive 32 MB; if 32 MB is not available,
       the controller will receive 16 MB; if 16 MB is not available, the
       bridge will receive 8 MB; and so on down to a minimum assignment of 1
       MB in configurations where memory is too constrained for the operating
       system to provide a larger window.
       Two 256-byte I/O windows"
    So I think we have our answer. Windows uses one 4k window, and one 64MB
    window. And they are no more dynamic than we are (we _could_ try to do it
    dynamically, but let's face it, it's fairly painful to dynamically expand
    PCI bus resources - you may need to reprogram everything up to the root,
    so it would be absolutely crazy to do that unless you have some serious
    masochistic tendencies).
    So let's just increase our default value to 64M too.
    Cc: Markus Rechberger <>
    Cc: Daniel Ritz <>
    Cc: Dominik Brodowski <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  23. [PATCH] relay: remove inlining

    Andrew Morton committed with Linus Torvalds
              text    data     bss     dec     hex filename
    before:   4036      44       0    4080     ff0 kernel/relay.o
    after:    3727      44       0    3771     ebb kernel/relay.o
    Cc: Mathieu Desnoyers <>
    Cc: Tom Zanussi <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  24. @jsgf

    [PATCH] ptrace: Fix EFL_OFFSET value according to i386 pda changes

    jsgf committed with Linus Torvalds
    The PDA patches introduced a bug in ptrace: it reads eflags from the wrong
    place on the target's stack, but writes it back to the correct place.  The
    result is a corrupted eflags, which is most visible when it turns interrupts
    off unexpectedly.
    This patch fixes this by making the ptrace code a little less fragile.  It
    changes [gs]et_stack_long to take a straightforward byte offset into struct
    pt_regs, rather than requiring all callers to do a sizeof(struct pt_regs)
    offset adjustment.  This means that the eflag's offset (EFL_OFFSET) on the
    target stack can be simply computed with offsetof().
    Signed-off-by: Jeremy Fitzhardinge <>
    Cc: Frederik Deweerdt <>
    Cc: Andi Kleen <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  25. @y-goto

    [PATCH] memory hotplug: fix compile error for i386 with NUMA config

    y-goto committed with Linus Torvalds
    Fix compile error when config memory hotplug with numa on i386.
    The cause of compile error was missing of arch_add_memory(),
    remove_memory(), and memory_add_physaddr_to_nid().
    Signed-off-by: Yasunori Goto <>
    Acked-by: David Rientjes <>
    Acked-by: Randy Dunlap <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  26. [PATCH] mips: if_fddi.h: Add a missing inclusion

    Maciej W. Rozycki committed with Linus Torvalds
    This is a change to include <linux/netdevice.h> in <linux/if_fddi.h> which is
    needed for "struct fddi_statistics".
    Signed-off-by: Maciej W. Rozycki <>
    Cc: Ralf Baechle <>
    Cc: Jeff Garzik <>
    Cc: "David S. Miller" <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  27. @tali

    [PATCH] kernel-doc: remove Martin from MAINTAINERS

    tali committed with Linus Torvalds
    I don't have the time to work on Linux Documentation, so I really should
    document that in MAINTAINERS.  With Randy, kernel-doc is in good hands
    Signed-off-by: Martin Waitz <>
    Cc: Randy Dunlap <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
  28. [PATCH] kernel-doc: allow unnamed structs/unions

    Randy Dunlap committed with Linus Torvalds
    Make kernel-doc support unnamed (anonymous) structs and unions.  There is
    one (union) in include/linux/skbuff.h (inside struct sk_buff) that is
    currently generating a kernel-doc warning, so this fixes that warning.
    Signed-off-by: Randy Dunlap <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>
Something went wrong with that request. Please try again.