change create-react-class to javascript class for to reduce the size … #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirjs
reviewed
Jan 6, 2018
src/chartsFactory.jsx
Outdated
| this.displayName = 'Highcharts' + chartType; | ||
| } | ||
|
|
||
| setChartRef = (chartRef) => { |
Owner
There was a problem hiding this comment.
How does this work?
Change to setChartRef(chartRef) ?
src/chartsFactory.jsx
Outdated
| if (!config) { | ||
| throw new Error('Config must be specified for the ' + this.displayName + ' component'); | ||
| } | ||
| let chartConfig = config.chart; |
kirjs
approved these changes
Jan 6, 2018
kirjs
reviewed
Jan 8, 2018
src/chartsFactory.jsx
Outdated
| } | ||
| } | ||
|
|
||
| if (cutCode) { |
Owner
There was a problem hiding this comment.
rename to isProdMode or something similar?
src/chartsFactory.jsx
Outdated
| renderTo: this.chartRef | ||
| function chartsFactory(chartType, Highcharts) { | ||
|
|
||
| class Charts extends Component { |
kirjs
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of the source file