Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example webpack config files should externalize dependencies #188

Open
awhitty opened this issue Sep 15, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@awhitty
Copy link

commented Sep 15, 2017

Do you want to request a feature, report a bug or ask a question?
Request a feature

What is the current behavior?
The examples in this repo include a build/main.js file. The custom runtime generator examples happen to import React and include the entire source code for React in the output.

What is the expected behavior?
It would be more useful as documentation to mark React and other similar dependencies as externals in the webpack configuration. It's currently almost impossible to see the output unique to this library when looking at https://github.com/kisenka/svg-sprite-loader/blob/master/examples/custom-runtime-generator/build/main.js

If this is a feature request, what is motivation or use case for changing the behavior?
Documentation should involve the fewest concepts possible to explain the idea it's documenting. Given that the output produced with the webpack config is part of the documentation, the source code to React (and other deps) is pretty auxiliary to the example and shouldn't be in the output.

@kisenka

This comment has been minimized.

Copy link
Owner

commented Sep 19, 2017

@awhitty could you please make a PR?

@awhitty

This comment has been minimized.

Copy link
Author

commented Sep 19, 2017

Sure!

@cletusw

This comment has been minimized.

Copy link

commented Oct 2, 2017

@awhitty Any progress on this? I totally agree!

@kisenka

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2017

@awhitty ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.