Update documentation and function name

kishaningithub · Mar 8, 2020 · 42c1cc6 · 42c1cc6
1 parent 73f2f8b
commit 42c1cc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmd/shopify-csv-download/main.go b/cmd/shopify-csv-download/main.go
@@ -19,7 +19,7 @@ func main() {
 	exitOnFailure(fmt.Sprintf("unable to parse url %s", productsJsonURL), err)
 	logWithNewLine("Downloading products as CSV...")
 	watch := stopwatch.Start()
-	err = products.SaveAsImportableCSVWithProgressState(*productsJsonURL, os.Stdout, progressHandler)
+	err = products.SaveAsImportableCSVNotifyingProgressState(*productsJsonURL, os.Stdout, progressHandler)
 	exitOnFailure("unable to write products", err)
 	logWithNewLine("")
 	watch.Stop()

diff --git a/pkg/products/writer.go b/pkg/products/writer.go
@@ -17,8 +17,8 @@ func SaveAsImportableCSV(productsJsonURL url.URL, out io.Writer) error {
 	return <-err
 }
 
-// SaveAsImportableCSVWithProgressState saves products from the given url to given writer and returns the progress state using channels
-func SaveAsImportableCSVWithProgressState(productsJsonURL url.URL, out io.Writer, onProgressHandler ProgressHandler) error {
+// SaveAsImportableCSVNotifyingProgressState saves products from the given url to given writer and notifies the progress state
+func SaveAsImportableCSVNotifyingProgressState(productsJsonURL url.URL, out io.Writer, onProgressHandler ProgressHandler) error {
 	progressState, err := products.
 		Stream(productsJsonURL).
 		ConvertToCSV().