Add native Python 3 support #17

Merged
merged 3 commits into from Mar 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

myint commented Mar 8, 2013

This adds Python 3 support without relying on 2to3. This allows for easier testing on Python 3.3. Note that I've re-enabled Python 3.3 on Travis CI, since it should work now.

myint added some commits Mar 8, 2013

Add better Python 3 support
This adds Python 3 support without relying on 2to3. This allows for
easier testing on Python 3.3.
test/test.py
@@ -29,7 +31,7 @@ def run_completer(self, parser, command, point=None):
with self.assertRaises(SystemExit):
autocomplete(parser, output_stream=t, exit_method=sys.exit)
t.seek(0)
- return t.read().split(IFS)
+ return t.read().decode('utf-8').split(IFS)
@kislyuk

kislyuk Mar 9, 2013

Owner

Is it better to use locale.getpreferredencoding here?

@myint

myint Mar 9, 2013

Contributor

Good point.

kislyuk added a commit that referenced this pull request Mar 9, 2013

Merge pull request #17 from myint/python3
Add native Python 3 support

@kislyuk kislyuk merged commit 89b2697 into kislyuk:master Mar 9, 2013

1 check passed

default The Travis build passed
Details
Owner

kislyuk commented Mar 9, 2013

Awesome, thanks.

@myint myint deleted the myint:python3 branch Apr 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment