make kismet compile on macOS (with XCode 8.0.0, clang-800.0.38) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We’re getting „using namespace std;“ from config.h, so this fixes compilation errors with clang at least.
On macOS/clang, this makes kismet compile. TODO: The return code is not checked at all.
|
Awesome, thanks! Sorry for the delay, github didn't send me a notice about it, time to check my settings. Merging and pushing now w/ minor changes to squash warnings about return vals on linux |
|
Also if there's anything else I need to do on the github side to make it credit you let me know, I'm not terribly familiar w/ how they do things, but I did the pull w/ the commit credits and all so it hopefully is happy! |
Closed
Open
kismetwireless
pushed a commit
that referenced
this pull request
Nov 24, 2019
fix help message, pointing to kis_log_device_rate
kismetwireless
pushed a commit
that referenced
this pull request
Mar 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.