Allow to override build date with SOURCE_DATE_EPOCH #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Note: This date call is designed to work with different flavors of date (GNU, BSD and others). If only GNU (Linux) support is needed, the patch can be simplified. This re-adds this patch to the release branch after it was accidentally lost in commit 7045475
|
This looks to be in conflict with existing changes in makefile.in which already define source date (and this actual pull req tries to revert a bunch of other stuff so i can't pull it directly anyhow); not sure how this differs from what's already there tho. |
|
You are probably looking at the master version, which got this already via #195 but this PR is targeted at the kismet-2020-04 branch where the change was accidentally lost and should be re-added. |
|
Yep that's exactly what I did, fair enough!
…On Mon, Jul 13, 2020 at 9:09 AM Bernhard M. Wiedemann < ***@***.***> wrote:
You are probably looking at the master version, which got this already via
#195 <#195> but this PR is
targeted at the kismet-2020-04 branch where the change was accidentally
lost
<7045475>
and should be re-added.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZAOCEAUNQFH2IPRKOCGYLR3MBRPANCNFSM4OYLSZEQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.
This re-adds the patch from #195 to the release branch
after it was accidentally lost
in commit 7045475 by @bergeraaron