Automatic detection of PIDs in existing HTML#365
Merged
Conversation
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
…ation Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Add other stencil targets
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
should be contained in gitignore
…triggers Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
…ht options Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
…root Replace Playwright e2e tests with Vitest browser-mode equivalents, add vitest.config.ts and vitest-setup.ts, remove the per-package Storybook configuration (.storybook/) since it now lives at the monorepo root, and update package.json scripts, tsconfig, and eslint config accordingly.
Set up the monorepo-root Storybook using @storybook/web-components-vite with composition refs for React (Vite), React (Next.js), Vue 3, and Angular sub-Storybooks. Add build-storybook pipeline that builds each child Storybook and copies output to react-vite/, react-nextjs/, vue/, and angular/ subdirectories. Include vitest config for Storybook tests, background/a11y parameters, and concurrently-based dev scripts.
Configure @storybook/react-vite with viteFinal aliases for Stencil package resolution. Include PidComponent stories covering all PID types, dark/light/system mode, and renderer selection. Add comprehensive auto-detection stories demonstrating initPidDetection() with mixed PIDs, filtered renderers, dark mode, excluded elements, tables, controller lifecycle, and punctuation handling. Remove CopyButton/JsonViewer stories (kept only in the root Stencil Storybook).
Configure @storybook/vue3-vite with viteFinal aliases for Stencil package resolution. Include PidComponent stories and comprehensive auto-detection stories using Vue composition API (defineComponent with onMounted/onUnmounted). Remove CopyButton/JsonViewer stories.
Configure @storybook/angular with webpackFinal aliases to resolve Stencil package subpaths that webpack cannot handle through exports maps. Add standalone tsconfig.storybook.json to avoid declarationDir conflicts. Include PidComponent stories and auto-detection stories using play() functions with dynamic imports. Remove CopyButton/JsonViewer stories.
Create packages/nextjs-app as a private (non-published) Next.js app that consumes @kit-data-manager/react-pid-component. Configure Storybook with @storybook/nextjs-vite and viteFinal aliases. Include PidComponent stories and comprehensive auto-detection stories with controller lifecycle demo. The app serves as both an integration test and a Storybook sub-project deployed at /react-nextjs.
Update deploy-storybook workflow to build all sub-Storybooks and deploy the composed output to GitHub Pages. Update npm-ci and Chromatic workflows for the new monorepo structure. Add storybook-static to .gitignore, update lerna.json, and refresh package-lock.json.
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
🎨 Chromatic Visual Tests✅ No visual changes ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
🎨 Chromatic Visual Tests✅ No visual changes ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
🎨 Chromatic Visual Tests🔍 Visual changes detected ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
🎨 Chromatic Visual Tests🔍 Visual changes detected ReviewChromatic provides automated visual testing and review for component changes. |
Test ResultsCoverage Summary
Coverage & Quality Reports📊 Codecov Report For more details, check the workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.