This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Repository navigation
Build feature for using a vendored protobuf compiler - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exploring Shuttle compatibility, we noticed that there was no protobuf compiler installed in their build environment and that there is also no way to install one.
This PR adds a feature gated behind
vendored-protocon thekitsune-search-protocrate that uses a vendored binary from theprotoc-bin-vendoredcrate to build the proto definitions with.This isn't intended as a permanent addition, but as an optional feature it doesn't hurt to have it.
Related to #78