Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin version and Remove AndroidMaven #560

Merged
merged 1 commit into from Dec 9, 2018
Merged

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Dec 9, 2018

Description

New Kotlin Version
Remove un-necessary AndroidMaven

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@iNoles iNoles self-assigned this Dec 9, 2018
@iNoles iNoles requested a review from kittinunf December 9, 2018 02:48
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #560   +/-   ##
=========================================
  Coverage     73.64%   73.64%           
  Complexity      317      317           
=========================================
  Files            52       52           
  Lines          1290     1290           
  Branches        188      188           
=========================================
  Hits            950      950           
  Misses          253      253           
  Partials         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28c788...faab930. Read the comment docs.

@iNoles iNoles merged commit 101aa7a into master Dec 9, 2018
@iNoles iNoles deleted the iNoles-patch-1 branch December 9, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants