Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Custom Moshi #614

Closed
wants to merge 1 commit into from

Conversation

@ProjectZed
Copy link
Contributor

commented Mar 23, 2019

Description

Implementation for #609 which allows providing a customized instance of Moshi for Fuel to use.

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

Need help writing unit tests for this because I'm unfamiliar with the testing framework that's been setup. No tests have broken though.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why
@ProjectZed ProjectZed marked this pull request as ready for review Mar 24, 2019
@codecov

This comment has been minimized.

Copy link

commented Mar 24, 2019

Codecov Report

Merging #614 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #614      +/-   ##
============================================
- Coverage     71.52%   71.45%   -0.07%     
  Complexity      296      296              
============================================
  Files            54       54              
  Lines          1433     1433              
  Branches        189      190       +1     
============================================
- Hits           1025     1024       -1     
  Misses          321      321              
- Partials         87       88       +1
Impacted Files Coverage Δ Complexity Δ
...otlin/com/github/kittinunf/fuel/moshi/FuelMoshi.kt 40% <66.66%> (-10%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abba79d...eda49ce. Read the comment docs.

@iNoles

This comment has been minimized.

Copy link
Collaborator

commented Mar 24, 2019

Looks like Codecov is not happy. would you added a test for it?

@iNoles iNoles closed this in #630 May 2, 2019
@ProjectZed ProjectZed deleted the ProjectZed:feature/custom-moshi branch May 12, 2019
@kittinunf kittinunf referenced this pull request May 12, 2019
3 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.