Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup HttpClient #639

merged 15 commits into from Jul 21, 2019


Copy link

commented May 23, 2019


HttpClient deserve to be refracting with many areas. As for Hook, InputStream is now nullable. I am moving httpExchangeFailed to the different area. I added the connect() to make sure it is connected. I am planning to add more later on.

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.


  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why
iNoles added 2 commits May 6, 2019
interpretResponseStream should have InputStream as nullable.
Move hook.httpExchangeFailed to different area.
@iNoles iNoles self-assigned this May 23, 2019

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5cc452c). Click here to learn what that means.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #639   +/-   ##
  Coverage          ?   71.39%           
  Complexity        ?      297           
  Files             ?       57           
  Lines             ?     1489           
  Branches          ?      192           
  Hits              ?     1063           
  Misses            ?      334           
  Partials          ?       92
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/kittinunf/fuel/stetho/StethoHook.kt 45.45% <ø> (ø) 0 <0> (?) 0% <ø> (ø) 0 <0> (?)
...tlin/com/github/kittinunf/fuel/core/DefaultHook.kt 100% <100%> (ø) 2 <1> (?) 76.85% <52.17%> (ø) 29 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc452c...a71a353. Read the comment docs.

@iNoles iNoles marked this pull request as ready for review May 24, 2019
@iNoles iNoles requested review from markGilchrist, kittinunf and SleeplessByte and removed request for markGilchrist and kittinunf May 24, 2019
iNoles added 4 commits May 25, 2019
…into cleanup_httpclient
Didn't work too well
iNoles added 4 commits May 28, 2019

This comment has been minimized.

Copy link

commented Jul 2, 2019

This looks like it is good to go, right? 😄

@iNoles iNoles removed the request for review from markGilchrist Jul 6, 2019
iNoles added 2 commits Jul 6, 2019
@iNoles iNoles requested a review from SleeplessByte Jul 6, 2019

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 21, 2019

@SleeplessByte it is ready to merge with your suggestions.

Sent with GitHawk

@SleeplessByte SleeplessByte merged commit f46bd4f into master Jul 21, 2019
4 checks passed
4 checks passed
codecov/patch No report found to compare against
codecov/project No report found to compare against
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@delete-merged-branch delete-merged-branch bot deleted the cleanup_httpclient branch Jul 21, 2019
@kittinunf kittinunf referenced this pull request Jul 22, 2019
3 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.