Switch to styled-components #5
Conversation
| <S.Link target="_blank" rel="noopener" href="https://github.com/kitze/twizzy-landing">View source</S.Link> | ||
| <S.Link target="_blank" rel="noopener" href="https://github.com/kitze/twizzy-landing"> | ||
| View source | ||
| </S.Link> |
There was a problem hiding this comment.
Prettier auto-formatted
| disableEsLint, | ||
| addBabelPlugin | ||
| } = require('customize-cra'); | ||
| const { override, disableEsLint, addBabelPlugin } = require('customize-cra'); |
There was a problem hiding this comment.
Prettier auto-formatted
|
@mxstbr hmm I thought styled-components will fail because things like |
|
Yep! We added support for that recently. Object styles are now a first-class citizen! |
|
Merged. Dammit @mxstbr your marketing game is 💯️ I went from aphrodite -> styled-components -> glamorous -> emotion -> styled-components. |
|
This is kinda a weird PR to me - maybe because I'm more involved in developing emotion but I love both projects. It's weird to me because nothing was really added, no argument was given in favour of the change. Seems like a marketing/power grab move to me, which doesn't sound nice. I don't want to accuse anyone of anything, but this is really strange to me. That being said ofc anyone is free to use any solution they want 😉 If this was intended more as a joke (not necessarily a bad one, it only shows how both projects are interoperable ❤️ ) then it's fine. Maybe Im just weird that it has surprised me 😅 |
|
Definitely a joke |
(I didn't think 
(yes it works)