spec file: cast paths in source.exclude_dirs to lowercase #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths tested against source.exclude_dirs are already cast to lowercase but previously the paths in source.exclude_dirs were left as-is. This could result in confusion if the user lists non-lowercase paths in source.exclude_dirs as they would never match anything.
tito
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paths tested against
source.exclude_dirs(set in buildozer.spec) are cast to lowercase but the paths in source.exclude_dirs are left as-is:buildozer/buildozer/__init__.py
Line 775 in 182d13f
buildozer/buildozer/__init__.py
Line 784 in 182d13f
This could result in confusion if the user lists non-lowercase paths in source.exclude_dirs as they would never match anything.