New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batching issue in animation update loop #143

Merged
merged 2 commits into from Jun 17, 2016

Conversation

Projects
None yet
2 participants
@udiboy1209
Member

udiboy1209 commented Jun 16, 2016

@Kovak tested with py3 and py2 both 馃槢.

We should consider making unit tests for kivent, adding every possible case to
the examples makes them very cluttered

@Kovak

This comment has been minimized.

Contributor

Kovak commented Jun 17, 2016

There are a few unused variable declarations in the update function that need to be removed, otherwise this looks excellent. 馃憤

@udiboy1209

This comment has been minimized.

Member

udiboy1209 commented Jun 17, 2016

@Kovak removed those unused variables. How do you check such things for cython? haven't found anything yet.

@Kovak

This comment has been minimized.

Contributor

Kovak commented Jun 17, 2016

A good IDE might be able to detect it, I usually just check manually.

@Kovak Kovak merged commit 41f2780 into kivy:2.2-dev Jun 17, 2016

@udiboy1209 udiboy1209 deleted the udiboy1209:animation_fixes branch Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment