New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python/hostpython recipes for Python 2.7.13 #242
Conversation
…on (2.7.13) with appropriate changes to patches and build recipes.
|
I've not tested any recipes beyond those pulled in by openssl and kivy. An archived app appears to make it through the automated App Store checks for internal beta testing on TestFlight and can be loaded onto real devices. |
|
Thanks for this - there is a lot of work here. I'll do some testing myself and let you know. |
|
Running OSX 10.10.5, XCode 7.2. After a 'git clean -dxf', and checking out this branch, then running I get the following: |
|
Have you tried |
|
Still get an error. Full output here: https://gist.github.com/Zen-CODE/d515859d2d06fe02b8e7ad3c52c8b7b6 |
|
This seems to be down to my hasty workaround for the OpenSSL dependancy of the updated hostpython. It probably shouldn't have worked at all, and clearly doesn't work on all versions of macOS. I can think of a couple of ways to do it properly.
I favour option 2 as it avoids any potential version mismatch issues. I'll see what I can whip up when I have some spare minutes. |
|
Yes, I agree option 2 would be preferable. And any minutes you can whip together are appreciated. Getting these changes into master would be really nice...:-) |
|
Hopefully this works. hostopenssl should be pulled in if openssl is requested. |
|
Pulled latest changes, 'git clean -dxf', './toolchain.py kivy openssl pyobjus', gives the error below. Please ask if you need more. |
|
A second run gets me further. |
|
Unfortunately I've not been able to reproduce your problem on 10.10.5. Clearly there's a difference in our configuration. What do you get from |
|
The last error seems to indicate the zlib is try to load Tcl/Tk and fails. Trying to load Tkinter on that makes dies and closes Python. Reading up, it seems Tkinter is very problematic on Mac. Could that be the cause? I'm trying to get Tkinter running on that mac and will let you know. Am I on the right track? |
|
Possibly, although I still think it's worth figuring out why a build works for me on a clean, up-to-date OSX 10.10.5 but not for you. Feel free to follow up on the Tkinter idea. I'm away from a computer for a couple of days so will pick up when I'm back. |
|
Firstly, thanks for the PR. There are some changes here that are really nice. But there is just too much happening here for us to merge safely into master. Too many things being changed that cannot be safely tested in isolation. It's our obligation to users to prevent undesired side effects. Please could we ask that you separate these into independent PR"s that address one issue at a time. Atomic merges are ideal: merges that address one issue cleanly and clearly. They are not only less error prone, but make tracking errors down the line much easier. So, if this PR could be separated into a series of PR"s that introduce the suggested changes one, test-able step at a time, we would be grateful .e.g. "Upgrade Python to 2.7.13", then "Upgrade openssl (1.0.2k)" etc. This would also make it much easier to see where strange errors creep in e.g. the tcl/tk issue. |
Version bumps for SDL2 (2.0.5), openssl (1.0.2k), python and hostpython (2.7.13) with changes to patches and build recipes.