KEP: allow tuple/list coordinates for Line.points

[kived]

Could be handled at assignment time.

if points and isinstance(points[0], (list, tuple)):
    points = list(itertools.chain(*points))

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[spinningD20]

Thanks for suggesting this officially. I would think most use-cases in kivy for Line points would be tuples or something similar, like widget.pos, widget.center. Is there a use case where a list of x, y, x, y makes more sense?

[udiboy1209]

I'd like to work on this issue! Could you tell me where to start ?

[tshirtman]

I'd say here
https://github.com/kivy/kivy/blob/master/kivy/graphics/vertex_instructions_line.pxi#L675-L677

[udiboy1209]

I made the change suggested by @kived and tried testing it using the lines example: https://github.com/kivy/kivy/blob/master/examples/canvas/lines.py#L142

When I run the example as it is, it works. But when I change the points declaration to this

points = ListProperty([(500, 500), 300, 300, 500, 300, 500, 400, 600, 400])

it shows error:

Exception TypeError: 'a float is required' in 'kivy.graphics.vertex_instructions.SmoothLine.build_smooth' ignored

I dont know whats wrong and what float is required? Does it mean that the elements in the list (coordinate values) should be float, but it is getting a tuple? (which would mean the change isn't working). Please help!

[dessant]

Fixed in #3866.