New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #6008

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@bmwiedemann
Contributor

bmwiedemann commented Oct 23, 2018

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, kivy/version.py would differ thusly:

 # THIS FILE IS GENERATED FROM KIVY SETUP.PY
 __version__ = '1.10.1'
 __hash__ = 'Unknown'
-__date__ = '20181022'
+__date__ = '20331124'
Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
@welcome

This comment has been minimized.

welcome bot commented Oct 23, 2018

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@tito

tito approved these changes Oct 23, 2018

@tito tito merged commit 655e8df into kivy:master Oct 23, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment