Add functions for obtaining the default storage paths #1598

ghost · 2019-01-17T21:29:03Z

We just discussed this on discord and the situation with the storage available on Android is a little bit confusing, so I read through the docs a little and wrote an additional storage module to add after #1528 is in. Still untested / to be polished

ghost · 2019-01-17T21:36:46Z

By the way I'm aware this might be covered by plyer, but this is so basic (especially app_storage_path()) that it really should be available easily without additional larger dependencies, and without this apps like even kivy actually (or mine, admittedly) may hardcode /sdcard which may not actually exist on some oddball devices!

Therefore, I think this should be added & documented in the p4a core android module (I will add documentation once the SDL2 pull request is in, since that one touches the doc section I'd also need to modify here so that will most likely leave me in conflict territory if I do that now)

inclement

Sounds good to me, I agree that this kind of thing is what the android module should be for. We've also just been talking about replacing the old cython stuff in the android module.

I added a couple of comments but not sure if you were still working on it anyway.

pythonforandroid/recipes/android/src/android/storage.py

inclement · 2019-01-30T13:32:24Z

pythonforandroid/recipes/android/src/android/storage.py

+        "primary external storage path"
+    )
+
+def secondary_external_storage_path():


Am I right to read that this function is actually identical to the previous one?

the isExternalStorageRemovable condition is different, which marks the difference between internal and external storage

doc/source/apis.rst

AndreMiras · 2019-06-29T18:01:51Z

pythonforandroid/recipes/android/src/android/storage.py

+        if p is not None:
+            if os.path.exists(os.path.join(p, "Documents")):
+                # Looks like it's properly mounted!
+                return True


Minor: simply go with:

return os.path.exists(os.path.join(p, "Documents"))

AndreMiras · 2019-06-29T18:27:58Z

This is looking promising @Jonast what about fixing the little conflict and make it to the tree?

ghost · 2019-07-09T20:19:55Z

Sounds good, although it should still be tested (I haven't so far 😂 ) - I'll give it a try and report back, and anyone else is also open to do so

pythonforandroid/recipes/android/src/android/storage.py

AndreMiras · 2019-07-18T21:15:23Z

Thanks for updating, it looks good overall, but fails runtime with:

AttributeError: type object 'android.os.Build' has no attribute 'VERSION'

The fix is fairly easy and I'd be happy to test once you have updated the PR

AndreMiras · 2019-07-28T14:23:39Z

Hi @Jonast I'm about to give that one another try. Could you also rebase upstream/develop?

AndreMiras · 2019-07-28T20:39:39Z

I gave it a try and it's crashing. I'm working on a fix and I'll add commits to the PR.
One of the crash could have been easily caught by unit testing. I'll work on that too later

ghost · 2019-07-28T20:47:34Z

Let me know if you need branch access on the repo fork itself, I really wouldn't mind giving you! I want to know how these "adding a commit" things work 😄 and thanks for taking over, that's nice 🙂 (I can also work on some tests though if you want me to)

AndreMiras · 2019-07-28T21:00:58Z

I think access to your fork is only if I want to push force, for adding commits it should be just fine now.
I'll let you know.
I can work on the unit test I don't mind and I know what broke hence what to test.

1) fixes isExternalStorageRemovable is expecting a file object, error was: ``` 07-28 16:36:46.845 2152 2784 I python : File "/home/andre/workspace/EtherollApp/.buildozer/android/platform/build/build/python-installs/etheroll/android/storage.py", line 61, in primary_external_storage_path 07-28 16:36:46.847 2152 2784 I python : File "jnius/jnius_export_class.pxi", line 1034, in jnius.jnius.JavaMultipleMethod.__call__ 07-28 16:36:46.848 2152 2784 I python : jnius.jnius.JavaException: No methods matching your arguments, available: ['()Z', '(Ljava/io/File;)Z'] ``` 2) fixes `os.path.exists()` doesn't accept `None`, error was: 07-28 22:31:25.877 31203 31313 I python : File "/home/andre/workspace/EtherollApp/.buildozer/android/platform/build/build/python-installs/etheroll/android/storage.py", line 101, in secondary_external_storage_path 07-28 22:31:25.878 31203 31313 I python : File "/home/andre/workspace/EtherollApp/.buildozer/android/platform/build/build/other_builds/python3-libffi-openssl-sqlite3/armeabi-v7a__ndk_target_21/python3/Lib/genericpath.py", line 19, in exists 07-28 22:31:25.879 31203 31313 I python : TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType 3) fixes on services `PythonActivity.mActivity` is None, refs kivy/kivy#6388

AndreMiras · 2019-07-28T21:11:33Z

I edited through the GitHub UI, I hope I didn't do a mess 😁
I'm going to re-test it from scratch now see how it goes. If things run OK and build is green I'll merge

AndreMiras

Runtime is just working perfectly. Here're some trace for outputs from both Python app and service.

07-28 23:19:09.647 10894 11303 I python  : app_storage_path: /data/user/0/com.github.andremiras.etheroll/files
07-28 23:19:09.661 10894 11303 I python  : primary_external_storage_path: /storage/emulated/0
07-28 23:19:09.665 10894 11303 I python  : secondary_external_storage_path: None
07-28 23:19:09.665 10894 11303 I python  : persistent_keystore_path: /sdcard/etheroll
07-28 23:19:09.665 10894 11303 I python  : non_persistent_keystore_path: /data/user/0/com.github.andremiras.etheroll/files

07-28 23:19:10.407 11414 11430 I service : app_storage_path: /data/user/0/com.github.andremiras.etheroll/files
07-28 23:19:10.412 11414 11430 I service : primary_external_storage_path: /storage/emulated/0
07-28 23:19:10.417 11414 11430 I service : secondary_external_storage_path: None
07-28 23:19:10.417 11414 11430 I service : persistent_keystore_path: /sdcard/etheroll
07-28 23:19:10.419 11414 11430 I service : non_persistent_keystore_path: /data/user/0/com.github.andremiras.etheroll/files

Code producing that output was:

from android import storage
app_storage_path = storage.app_storage_path()
print(f'app_storage_path: {app_storage_path}')
primary_external_storage_path = storage.primary_external_storage_path()
print(f'primary_external_storage_path: {primary_external_storage_path}')
secondary_external_storage_path = storage.secondary_external_storage_path()
print(f'secondary_external_storage_path: {secondary_external_storage_path}')
persistent_keystore_path = cls.get_persistent_keystore_path()
print(f'persistent_keystore_path: {persistent_keystore_path}')
non_persistent_keystore_path = cls.get_non_persistent_keystore_path()
print(f'non_persistent_keystore_path: {non_persistent_keystore_path}')

Will merge once Travis turns green

ghost · 2019-07-28T21:39:19Z

Neat! Actually looking forward to use this myself in my apps ❤️ it's an overdue addition for sure

Sahil-pixel · 2020-11-01T14:01:22Z

path of secondary storage is none ..please fix this
: secondary_external_storage_path: None

inclement reviewed Jan 30, 2019

View reviewed changes

inclement changed the base branch from master to develop June 6, 2019 20:40

ghost mentioned this pull request Jun 18, 2019

App.user_data_dir to work on Android service kivy/kivy#6388

Open

AndreMiras reviewed Jun 29, 2019

View reviewed changes

doc/source/apis.rst Show resolved Hide resolved

AndreMiras reviewed Jun 29, 2019

View reviewed changes

AndreMiras mentioned this pull request Jun 29, 2019

Hardcoded /sdcard/ call AndreMiras/EtherollApp#145

Open

ghost added the need-testing label Jul 9, 2019

ghost changed the title ~~[WIP] Add functions for obtaining the default storage paths~~ Add functions for obtaining the default storage paths Jul 9, 2019

AndreMiras reviewed Jul 18, 2019

View reviewed changes

pythonforandroid/recipes/android/src/android/storage.py Outdated Show resolved Hide resolved

AndreMiras reviewed Jul 18, 2019

View reviewed changes

pythonforandroid/recipes/android/src/android/storage.py Outdated Show resolved Hide resolved

Add functions for obtaining the default storage paths

7d5fdee

AndreMiras approved these changes Jul 28, 2019

View reviewed changes

AndreMiras merged commit e21cd8b into kivy:develop Jul 28, 2019

ghost deleted the storage_android branch July 28, 2019 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add functions for obtaining the default storage paths #1598

Add functions for obtaining the default storage paths #1598

ghost commented Jan 17, 2019

ghost commented Jan 17, 2019 •

edited by ghost

Loading

inclement left a comment

inclement Jan 30, 2019

ghost Jan 30, 2019

AndreMiras Jun 29, 2019

AndreMiras commented Jun 29, 2019

ghost commented Jul 9, 2019

AndreMiras commented Jul 18, 2019

AndreMiras commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

ghost commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

AndreMiras left a comment

ghost commented Jul 28, 2019

Sahil-pixel commented Nov 1, 2020

Add functions for obtaining the default storage paths #1598

Add functions for obtaining the default storage paths #1598

Conversation

ghost commented Jan 17, 2019

ghost commented Jan 17, 2019 • edited by ghost Loading

inclement left a comment

Choose a reason for hiding this comment

inclement Jan 30, 2019

Choose a reason for hiding this comment

ghost Jan 30, 2019

Choose a reason for hiding this comment

AndreMiras Jun 29, 2019

Choose a reason for hiding this comment

AndreMiras commented Jun 29, 2019

ghost commented Jul 9, 2019

AndreMiras commented Jul 18, 2019

AndreMiras commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

ghost commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

AndreMiras commented Jul 28, 2019

AndreMiras left a comment

Choose a reason for hiding this comment

ghost commented Jul 28, 2019

Sahil-pixel commented Nov 1, 2020

ghost commented Jan 17, 2019 •

edited by ghost

Loading