New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing next release #699

Closed
ecaselles opened this Issue Sep 27, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@ecaselles
Member

ecaselles commented Sep 27, 2017

I would like to push a new release of Kiwi out to include what it is currently on master, plus the fixes needed to ensure compatibility with Xcode 9 (which we are currently working on).

Initially, the work included in this milestone would be:

  • Everything already merged to master since 2.4.0 (see diff)
  • Fixing CI builds (#703)
  • Fixing #698: renaming the any macro
  • Ensure compatibility with Xcode 9 (no warnings)
  • Release new version

I know there were conversations for the next release to be v3.0, but it feels like a minor version bump could be more appropriate, since most of the changes added are bug fixes, memory management improvements and other maintenance work.

@kiwi-bdd/core-team would you be happy for me to tag this release as v2.4.1 or would you rather continue with the plan of naming it v3.0 just for closure?

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Sep 27, 2017

Contributor

Dang, yeah, that's 2 years worth of PRs, should probably do it at 2.5 if there's no source breaking changes

Contributor

orta commented Sep 27, 2017

Dang, yeah, that's 2 years worth of PRs, should probably do it at 2.5 if there's no source breaking changes

@ecaselles

This comment has been minimized.

Show comment
Hide comment
@ecaselles

ecaselles Sep 27, 2017

Member

Thanks @orta, happy to go with 2.5 👍

The only potential breaking change could be the one we are about to introduce to fix #698. But we should be able check if any is defined beforehand, to keep backwards compatibility. 🙏 leave any suggestions there if you think there is a better way to fix it without breaking previous versions.

Member

ecaselles commented Sep 27, 2017

Thanks @orta, happy to go with 2.5 👍

The only potential breaking change could be the one we are about to introduce to fix #698. But we should be able check if any is defined beforehand, to keep backwards compatibility. 🙏 leave any suggestions there if you think there is a better way to fix it without breaking previous versions.

@grevolution

This comment has been minimized.

Show comment
Hide comment
@grevolution

grevolution Dec 7, 2017

any update on #698

grevolution commented Dec 7, 2017

any update on #698

@scottdensmore

This comment has been minimized.

Show comment
Hide comment
@scottdensmore

scottdensmore Dec 13, 2017

What is the plan for getting Xcode 9 support? Is this something that is going to be done?

scottdensmore commented Dec 13, 2017

What is the plan for getting Xcode 9 support? Is this something that is going to be done?

@ecaselles

This comment has been minimized.

Show comment
Hide comment
@ecaselles

ecaselles Dec 15, 2017

Member

Yes @scottdensmore. I will have a look at the work done by @SevInf and hopefully will try to get the new build out before the end of the year

Member

ecaselles commented Dec 15, 2017

Yes @scottdensmore. I will have a look at the work done by @SevInf and hopefully will try to get the new build out before the end of the year

@scottdensmore

This comment has been minimized.

Show comment
Hide comment
@scottdensmore

scottdensmore Dec 19, 2017

Thanks @ecaselles. Anything we can do to help?

scottdensmore commented Dec 19, 2017

Thanks @ecaselles. Anything we can do to help?

@ecaselles

This comment has been minimized.

Show comment
Hide comment
@ecaselles

ecaselles Dec 22, 2017

Member

@scottdensmore I am currently reviewing the two PRs opened by @SevInf and hoping to get a green build on #702. Not sure about #701, looks like if we can't keep backwards compatibility, it is just not a minor version bump.

Member

ecaselles commented Dec 22, 2017

@scottdensmore I am currently reviewing the two PRs opened by @SevInf and hoping to get a green build on #702. Not sure about #701, looks like if we can't keep backwards compatibility, it is just not a minor version bump.

@ecaselles ecaselles changed the title from Preparing next maintenance release to Preparing next release Jan 8, 2018

@ecaselles

This comment has been minimized.

Show comment
Hide comment
@ecaselles

ecaselles Jan 8, 2018

Member

FYI I will be tagging this release as 3.0, as it will introduce breaking changes (#701)

Member

ecaselles commented Jan 8, 2018

FYI I will be tagging this release as 3.0, as it will introduce breaking changes (#701)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment