Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotels: RoomSummary and HotelCard on SingleHotelMap are also swipeabl… #1608

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
2 participants
@RobinCsl
Copy link
Collaborator

commented May 6, 2019

…e on Android

This fixes MOBILE-4113.

It seems that VerticalSwipeResponder does not like too much to be nested in View components for the swiping to work on Android. :man-shrugging:

These changes can be seen in Room Summary after selecting rooms and on the map view for a given hotel; it's now possible to swipe the card up on Android (was already working on iOS).

Another issue was spotted during this fix: the RoomSummary card computes the allowed space given for the price tag for SummaryRow component based on the width of the device, and it should be half the width in Tablet view. Issue created: #1607

Hotels: RoomSummary and HotelCard on SingleHotelMap are also swipeabl…
…e on Android

This fixes MOBILE-4113.

It seems that VerticalSwipeResponder does not like too much to be nested in `View` components for the swiping to work on Android. :man-shrugging:

These changes can be seen in Room Summary after selecting rooms and on the map view for a given hotel; it's now possible to swipe the card up on Android (was already working on iOS).

Another issue was spotted during this fix: the RoomSummary card computes the allowed space given for the price tag for SummaryRow component based on the width of the device, and it should be half the width in Tablet view. Issue created: #1607

@RobinCsl RobinCsl requested a review from mrtnzlml May 6, 2019

@RobinCsl RobinCsl requested a review from tbergq as a code owner May 6, 2019

@mrtnzlml
Copy link
Member

left a comment

(I am not trying to run these PRs since I believe you tried it and everything is OK.)

@RobinCsl

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

(I am not trying to run these PRs since I believe you tried it and everything is OK.)

Sure, thanks for letting me know. I did try on Android tablet and phone, and iOS iPhone and iPad simulators. I believe QA will pay extra attention anyway.

@RobinCsl RobinCsl merged commit 6055507 into master May 6, 2019

1 check passed

ci/gitlab/MOBILE-4113 Pipeline passed on GitLab
Details

@RobinCsl RobinCsl deleted the MOBILE-4113 branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.