Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create <Popover /> component #588

Closed
honzatmn opened this issue Nov 2, 2018 · 1 comment
Closed

Create <Popover /> component #588

honzatmn opened this issue Nov 2, 2018 · 1 comment
Assignees
@filipdanisko

Comments

@honzatmn
Copy link
Contributor

honzatmn commented Nov 2, 2018

Description

A popover can be used as a container for additional content that can be displayed on top of the page.

Visual style

popover

Zeplin: https://zpl.io/agrBvoM

Additional information

  • Popover can be used with different types of trigger, for example, Button, ButtonLink, Tag or TextLink. We shouldn't limit it to any specific component, a trigger can be basically anything clickable.
  • There is similar behavior for our search forms (layer on top of the page, containing original input). Not sure if Popover should solve it, I see that more as a new component - something like InputPopover, or similar.
  • You can find the proposed mobile behavior in Zeplin. It's copied from how Popovers behave in our mobile app (the Close button position). We need to discuss it and make it probably more consistent with Tooltip and Modal behavior (3 different patterns currently).
@vepor vepor self-assigned this Nov 27, 2018
@vepor vepor assigned filipdanisko and unassigned vepor Mar 12, 2019
@filipdanisko
Copy link
Contributor

Released in 0.39.0 #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipdanisko filipdanisko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@honzatmn @vepor @filipdanisko