Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: Accessibility of ChoiceGroup #1072

Merged
merged 5 commits into from Jun 5, 2019

Conversation

@filipdanisko
Copy link
Collaborator

commented May 30, 2019

Adding role="group" and aria-labelledby to ChoiceGroup to support screen readers.
To enable this. I'm extending <Heading> To contain id.


LiveURL: https://orbit-components-update-a11y-choicegroup.surge.sh

@filipdanisko filipdanisko added the WIP label May 30, 2019
src/Heading/README.md Outdated Show resolved Hide resolved
@filipdanisko filipdanisko requested a review from vepor Jun 5, 2019
@vepor
vepor approved these changes Jun 5, 2019
@vepor vepor merged commit 8882e0f into master Jun 5, 2019
2 checks passed
2 checks passed
ci/circleci: deploy-surge Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@vepor vepor deleted the update/a11y-choicegroup branch Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.