From a53f4f452297106fa727b354e00646eb08221fd6 Mon Sep 17 00:00:00 2001 From: Daniel Sil Date: Tue, 7 Feb 2023 16:29:42 +0100 Subject: [PATCH 1/3] chore: fix Accordion stories missing import --- packages/orbit-components/src/Accordion/Accordion.stories.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/orbit-components/src/Accordion/Accordion.stories.tsx b/packages/orbit-components/src/Accordion/Accordion.stories.tsx index ff942fd77f..a86c6752b1 100644 --- a/packages/orbit-components/src/Accordion/Accordion.stories.tsx +++ b/packages/orbit-components/src/Accordion/Accordion.stories.tsx @@ -1,4 +1,5 @@ import React from "react"; +import { action } from "@storybook/addon-actions"; import Text from "../Text"; import Button from "../Button"; From 77a387e59ae1ab6072d70f125bdc672ff4cb0ed9 Mon Sep 17 00:00:00 2001 From: Daniel Sil Date: Tue, 7 Feb 2023 16:30:15 +0100 Subject: [PATCH 2/3] chore: internally export StyledLabel on Radio --- packages/orbit-components/src/Radio/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/orbit-components/src/Radio/index.tsx b/packages/orbit-components/src/Radio/index.tsx index 33e8b667e5..2f730bcc7f 100644 --- a/packages/orbit-components/src/Radio/index.tsx +++ b/packages/orbit-components/src/Radio/index.tsx @@ -146,7 +146,7 @@ StyledInput.defaultProps = { theme: defaultTheme, }; -const StyledLabel = styled(({ disabled, theme, type, hasError, ...props }) => ( +export const StyledLabel = styled(({ disabled, theme, type, hasError, ...props }) => ( ))` ${({ theme, disabled }) => css` From 723dd5dda1d4bba538bc21102f03a8dfa939e1c6 Mon Sep 17 00:00:00 2001 From: Daniel Sil Date: Tue, 7 Feb 2023 16:31:07 +0100 Subject: [PATCH 3/3] feat(Text): element prop in StyledText now has `p` as defaultValue --- packages/orbit-components/src/Text/index.tsx | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/packages/orbit-components/src/Text/index.tsx b/packages/orbit-components/src/Text/index.tsx index 706a34b997..a1b015091e 100644 --- a/packages/orbit-components/src/Text/index.tsx +++ b/packages/orbit-components/src/Text/index.tsx @@ -75,11 +75,13 @@ const getLineHeightToken = ({ return lineHeightTokens[size]; }; -export const StyledText = styled(({ element: TextElement, children, className, dataTest, id }) => ( - - {children} - -))` +export const StyledText = styled( + ({ element: TextElement = ELEMENT_OPTIONS.P, children, className, dataTest, id }) => ( + + {children} + + ), +)` ${({ theme, align,