Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID to redis only after it has been sent successfully #11

Closed
underyx opened this issue Aug 31, 2016 · 0 comments
Closed

Add ID to redis only after it has been sent successfully #11

underyx opened this issue Aug 31, 2016 · 0 comments
Assignees
@iakat

Comments

@underyx
Copy link
Contributor

underyx commented Aug 31, 2016

An exception (textblob connection issues, Slack connection issues, anything) can cause reviews to be recorded in Redis without being sent to Slack. That's pretty bad.
@iakat iakat self-assigned this Aug 31, 2016
iakat pushed a commit that referenced this issue Sep 2, 2016
reviews: Retry Slack webhooks and add to Redis only when successful.
d5476e5 
Closes #11
@iakat iakat mentioned this issue Sep 2, 2016
Merged
iakat pushed a commit that referenced this issue Sep 2, 2016
reviews: Retry Slack webhooks and add to Redis only when successful.
6e2091b 
Closes #11
iakat pushed a commit that referenced this issue Sep 5, 2016
reviews: Retry Slack webhooks and add to Redis only when successful
ff8f5bd 
Closes #11
underyx pushed a commit that referenced this issue Sep 5, 2016
@underyx
reviews: Retry Slack webhooks and add to Redis only when successful
f801ee0 
Closes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iakat iakat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@underyx @iakat