New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset registered to false when opening a fresh connection #189

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
4 participants
@xPaw
Copy link
Contributor

xPaw commented Feb 1, 2019

No description provided.

@Zarthus

Zarthus approved these changes Feb 2, 2019

Copy link
Contributor

Zarthus left a comment

Tested, fixes the issue I encountered in referenced issue above.

@xPaw

This comment has been minimized.

Copy link
Contributor Author

xPaw commented Feb 2, 2019

I suspect this might affect reconnections as it relies on registered flag for that.

EDIT: On a second look through the code, it should continue working fine. If it's already doing reconnection attemps, it skips the registered checks.

@prawnsalad prawnsalad merged commit 1bedceb into kiwiirc:master Feb 9, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@xPaw xPaw deleted the xPaw:patch-2 branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment