Remove XmlRpcLog() model

Kiwi TCMS will no longer log RPC calls to the database. We feel like this is not very useful and it adds a small performance penalty. We can document how to do custom logging separately or if many people are using this functionality then it can be reverted back!
kiwitcms · Jul 18, 2018 · 1429ca5 · 1429ca5
1 parent 80cefa8
commit 1429ca5
Show file tree

Hide file tree

Showing 11 changed files with 21 additions and 200 deletions.
diff --git a/docs/source/modules/tcms.xmlrpc.admin.rst b/docs/source/modules/tcms.xmlrpc.admin.rst
diff --git a/docs/source/modules/tcms.xmlrpc.handlers.rst b/docs/source/modules/tcms.xmlrpc.handlers.rst
diff --git a/docs/source/modules/tcms.xmlrpc.models.rst b/docs/source/modules/tcms.xmlrpc.models.rst
diff --git a/docs/source/modules/tcms.xmlrpc.rst b/docs/source/modules/tcms.xmlrpc.rst
@@ -18,11 +18,8 @@ Submodules
 
 .. toctree::
 
-   tcms.xmlrpc.admin
    tcms.xmlrpc.decorators
    tcms.xmlrpc.forms
-   tcms.xmlrpc.handlers
-   tcms.xmlrpc.models
    tcms.xmlrpc.serializer
    tcms.xmlrpc.utils
 
diff --git a/tcms/settings/common.py b/tcms/settings/common.py
@@ -285,8 +285,6 @@
     'tcms.xmlrpc.api.user',
     'tcms.xmlrpc.api.version',
 ]
-# RPC handlers which can log RPC calls to the database
-MODERNRPC_HANDLERS = ['tcms.xmlrpc.handlers.XMLRPCHandler', 'tcms.xmlrpc.handlers.JSONRPCHandler']
 
 SESSION_ENGINE = 'django.contrib.sessions.backends.cached_db'
 

diff --git a/tcms/urls.py b/tcms/urls.py
@@ -38,7 +38,7 @@
 
     # Index and static zone
     url(r'^$', core_views.index, name='core-views-index'),
-    url(r'^xml-rpc/', RPCEntryPoint.as_view(protocol=XMLRPC_PROTOCOL), name='xml-rpc'),
+    url(r'^xml-rpc/', RPCEntryPoint.as_view(protocol=XMLRPC_PROTOCOL)),
     url(r'^json-rpc/$', RPCEntryPoint.as_view(protocol=JSONRPC_PROTOCOL)),
 
     # Ajax call responder

diff --git a/tcms/xmlrpc/admin.py b/tcms/xmlrpc/admin.py
diff --git a/tcms/xmlrpc/handlers.py b/tcms/xmlrpc/handlers.py
diff --git a/tcms/xmlrpc/migrations/0002_remove_xmlrpclog.py b/tcms/xmlrpc/migrations/0002_remove_xmlrpclog.py
@@ -0,0 +1,20 @@
+# Generated by Django 2.0.7 on 2018-07-18 13:52
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('xmlrpc', '0001_initial'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='xmlrpclog',
+            name='user',
+        ),
+        migrations.DeleteModel(
+            name='XmlRpcLog',
+        ),
+    ]
diff --git a/tcms/xmlrpc/models.py b/tcms/xmlrpc/models.py
diff --git a/tcms/xmlrpc/tests/test_logging.py b/tcms/xmlrpc/tests/test_logging.py