New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LooseCF and frieds in favor of django form fields #107

Closed
atodorov opened this Issue Nov 6, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@atodorov
Copy link
Member

atodorov commented Nov 6, 2017

In tcms.search.forms there are some "template-functions" which return django form field instances. ATM it is not clear why we need them but IMO they can be removed and instead we can declare form fields directly.

@atodorov atodorov added the refactoring label Nov 6, 2017

atodorov added a commit that referenced this issue Jan 9, 2018

Remove template functions. Fixes #107
the partial template function is used to create a simpler
signature of a method and to freeze some parameters, however this
isn't really necessary here and worsens code readability IMO.

@atodorov atodorov closed this in 6a4a8e6 Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment