Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordinary search and advanced search results use different templates #108

Closed
atodorov opened this Issue Nov 6, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@atodorov
Copy link
Member

atodorov commented Nov 6, 2017

For example when searching Test Runs there are 2 different templates used to display the results.

An ordinary search POSTs to an ajax view which returns JSON including HTML string via templates/run/common/json_runs.txt and the other uses an HTML template in templates/run/common/run_advance_filtered.html. This is the same for all search methods.

We should unify those because that makes adjusting the result columns or pagination easier.

On a related note we have to evaluate exactly how much more flexible Advanced search is compared to the other search views! I have the feeling that there isn't much of a difference and the Advanced search code seems to me unnecessarily complicated.

On this note there should probably be a single search class implementing the common search interface and then inherited versions adding specifics for Test Plans, Test Cases and Test Runs!

The templates themselves should be migrated to Patterfly once we have one or two of them left.

Related views returning JSON should return pure data, not strings containing HTML.

This is also related to #104

@atodorov atodorov added the refactoring label Nov 6, 2017

@atodorov

This comment has been minimized.

Copy link
Member Author

atodorov commented Jun 30, 2018

Note: as of now advanced search doesn't appear to be working but I haven't found out what broke it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.