New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API requests from anonymous user are not being recorded in production logs #126

Closed
okainov opened this Issue Nov 24, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@okainov
Contributor

okainov commented Nov 24, 2017

Description of problem

When API actions are performed as anonymous user, the logs are not available

Component (web, API, etc)

api

Version or commit hash (if applicable)

latest

How often reproducible

always

Steps to Reproduce

  1. Setup production \ non-debug enviironment
  2. Perform anonymous API call
  3. Check admin page with API logs
  4. Make sure the call was not recorded

Additional info

XmlRpcLog expects valid user which exists in database, but AnonymousUser is not a valid DB object, so creation of the entry is faling in tcms/xmlrpc/decorators.py

atodorov added a commit that referenced this issue Dec 5, 2017

Log XML-RPC requests from anonymous users. Fixes #126
we acomplish this by creating (if necessary) a special user object
with username=='Anonymous'.

Note: While it is possible to log the requests with user=None
the admin interface needs to be modified to support
displaying/filtering None values which is even more hassle.
This is the lest intrusive way to fix this problem!

@atodorov atodorov closed this in f92e75f Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment