Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
TagActions.remove must return a single data type #135
This method either returns a string or a tuple of (bool, object) which makes me wonder is the return value even used ! This obviously needs to be examined and rectified.
Update: while at it the method uses a
After investigating the issue it turned out that
The author of the code has left a comment, that a possible error could occur here if
Possible solution would be the return time of the
This is correct (mostly). The if condition will evaluate to True if the first letter of the error message is empty string or we return a tuple with first element False, which is not the case in practice.
A quick fix would be to
However the entire view function doesn't look right. All of the
@asankov if you want to continue working on this I suggest first adding some tests and then applying the quick fix before we can discuss anything further.